Skip to content

docs(upstream): record the Codebase Design workshop and correct five mattpocock-skills passages - #16550

Merged
kyle-sexton merged 5 commits into
mainfrom
docs/upstream-aihero-codebase-design
Nov 16, 2026
Merged

kyle-sexton merged 5 commits into
mainfrom
docs/upstream-aihero-codebase-design

Conversation

@kyle-sexton

Copy link
Copy Markdown
Member

No related issue: the record closes the Codebase Design workshop's absorb pass; each row links the pull request that landed it.

Summary

Adds the docs/upstream record for the Codebase Design workshop of AI Hero Cohort 005, and corrects five passages of the mattpocock-skills record that had gone stale.

Fix

Verification

Related

🤖 Generated with Claude Code

https://claude.ai/code/session_01MWmASLnS6k3MEmYoBnwDv3

kyle-sexton and others added 5 commits November 16, 2026 10:24
…mattpocock-skills passages

Adds the workshop 05 record: what this repository takes, adapts, already
has or rejects, with the pull request that landed each row. Corrects two
stale verdicts and one citation in the mattpocock-skills record, and
states the ADR-gate difference there.

Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01MWmASLnS6k3MEmYoBnwDv3
@kyle-sexton
kyle-sexton marked this pull request as ready for review November 16, 2026 15:41
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 16, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-16T15:42:59.125231Z e7df8f2 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

Copy link
Copy Markdown
Contributor

Lane run report

Field Value
Activity pr-refine/fix-docs
Model rung 0
Leg handoff
Run job success
Activity step success
Commits pushed none (read lane)
Run 43899149252

Failed GitHub API calls

Method Path Status
GET /repos/{repo}/git/ref/tags/* 404

@github-actions

Copy link
Copy Markdown
Contributor

claude-security-review reviewed e7df8f2c13b511035d7e98306834ae730fe7d558: read 2 of 2 changed file(s); 0 finding(s), 0 as inline comments.

Security review: no security issues found

critical-findings: 0

I read every hunk of both changed files:

  • docs/upstream/aihero-codebase-design.md is a new attribution record.
  • docs/upstream/mattpocock-skills.md gets five corrected passages: the yes-accepts wording is now recorded as adopted, the CDN scripts and Mermaid as taken (in the row and the map line), the domain-modeling line states how the decision-record gates differ, and one citation is corrected.

Why there is nothing to report

  • Prose only. Both files are attribution records under docs/upstream/. No code, workflow, plugin manifest, hook, skill or agent body, or CLAUDE.md/AGENTS.md changes.
  • No trusted paths or trust controls. Neither file matches a TRUSTED PATHS glob. The change touches no trust control: not the trusted-trigger check, the token broker or resolve-config, the kill switch, any merge hold, or any action under .github/actions/.
  • No instruction-surface deletions. No standing instruction is deleted, narrowed or softened. The edits change what the records say about past decisions and do not change any rule an agent follows.
  • CDN loading is only described here. The record now says rendered views may load a library from a CDN at an exact version with a fallback. The change that allows this landed in the cited pull requests (feat(rendered-views): let a view load a pinned CDN library with a fallback #16490, feat(architecture): build the deepening report on the shared chrome with pinned CDN diagrams #16508), not in this diff, so it is not reviewed here.
  • External links are inert. Every link to mattpocock/skills is pinned to commit 4ae2317ddb22b046e26455e4f9c9b3aaaf62212d. Links in docs execute nothing.
  • PR context is clean. The description contains no embedded directives aimed at this lane.

Prior findings: none. This lane had not reviewed an earlier head, so this was a full review, not blocking only.

@github-actions

Copy link
Copy Markdown
Contributor

claude-review reviewed e7df8f2c13b511035d7e98306834ae730fe7d558: read 2 of 2 changed file(s); 0 finding(s), 0 as inline comments.

Code review: PR #16550 (docs only, no findings)

I read every hunk of both changed files: docs/upstream/aihero-codebase-design.md (new) and docs/upstream/mattpocock-skills.md (five corrected passages). I found nothing that meets the bar for a finding.

What I checked against the repository at head:

  • Repository links: every link in the new record points to a file that exists. That covers the other aihero-*.md records, docs/glossary.md, the upstream-drift README and its #what-a-row-may-describe anchor, and every plugins/*/skills/*/SKILL.md target (architecture:improve, principles, enforce-boundaries, record-decision, planning:design, planning:interview, tdd:principles, work-items:ship, testing:write, playbooks:skill-authoring, corrections:codify).
  • The citation correction in the codebase-design row is accurate. interface-design.md#L85 is about a fresh-eyes reviewer dispatch, not the design subagents. Section "2. The briefs the subagents read" launches each design as its own subagent and never mentions a fresh context, which matches the new text.
  • The yes-accepts wording is recorded as adopted. plugins/planning/skills/interview/SKILL.md#L236 has the rule the record now cites.
  • The this record value in the Landed column follows existing practice: aihero-review.md and aihero-office-hours.md already use it.

Not checked by me: the PR description says scripts/check-affected.sh --tests passed and that all 20 cited PRs read MERGED. Both claims come from the author; I had no shell or GitHub access to confirm them.

Other inputs:

  • The pull request closes no issue, so there are no acceptance criteria to check.
  • There are no prior findings and no settled threads, so this was a full review, not a blocking-only one.
  • Neither changed file matches a trusted-path glob.
  • No plugin manifest is touched.
  • There is no cost impact.

Verifier dropped 0 of 0 candidates.

@kyle-sexton
kyle-sexton added this pull request to the merge queue Nov 16, 2026
Merged via the queue into main with commit 435d4b0 Nov 16, 2026
66 of 78 checks passed
@kyle-sexton
kyle-sexton deleted the docs/upstream-aihero-codebase-design branch November 16, 2026 16:02
@github-actions github-actions Bot added the merge-path: owner-agent Post-merge accounting record (README.md, Merge paths) label Nov 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge-path: owner-agent Post-merge accounting record (README.md, Merge paths)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant