Repository navigation
feat(review): flag authorization each route must opt in to - #16423
Conversation
The security reviewer's A01 row now covers authorization with no central decision point and no default deny, even when every current route carries its check, per OWASP Proactive Controls C1. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
claude-security-review reviewed Security review: no security issues foundI read all 9 changed files in full. What the change does
Trust controls and trusted paths
Embedded text: the PR description has no instructions aimed at this review lane. Spend: the new eval case runs 3 times, with critical-findings: 0 |
|
claude-review reviewed Code review: no findingsI read every hunk of all 9 changed files in What changes
What I checked
Spend: the new eval case adds 3 runs per eval pass (up to 40 turns and 900 s each), paid from prepaid API credit. It is not a hold. Verifier dropped 0 of 0 candidates. |
No related issue: owner decision from a design interview on the security review criteria (2026-11-14), recorded outside this repository.
Summary
review:security-reviewerlisted "missing authorization on endpoints" and nothing about where the decision is made. A change in which every route calls the role check itself passed, although the next route added without the call would be open.Fix
plugins/review/agents/security-reviewer.md: one clause and one link in the A01 row. No other review file changes.plugins/review/evals/qg-security-per-route-authorization-opt-in/: one outcome case, a branch adding three admin routes that each check the role inline.Verification
claude plugin eval --scaffold, plugin arm only, 3 runs: 3 of 3 passed. Each run dispatched the security reviewer and reported the opt-in structure with a single-place fix./review:quality-gateinvocation.validate-cases.pyoverplugins/review/evals: no FAIL;scripts/check-changelog-fragments.sh --check: valid.Related
plugins/review; it does not touchagents/security-reviewer.md's A01 row as of its head when this PR opened.🤖 Generated with Claude Code