Repository navigation
feat(planning): name the architecture skills in design and plan - #16422
Conversation
…a Later line /planning:design invokes /architecture:principles when the work changes module structure and names /architecture:improve for existing modules; /planning:plan names both in its prerequisite check. A /planning:interview round header gains one Later: line for the topics of rounds already known to follow. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
The paragraph sat in the interview skill's Stance section, whose digest interview-defenses.test.sh pins. This change no longer edits the interview skill; the Later line needs a re-pin and ships separately. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Lane run report
Failed GitHub API calls
|
|
claude-security-review reviewed Security review: PR #16422, head 8c9c8e8 (incremental since a33fec0)I found no security issues in this push. This lane already reviewed an earlier head, so this review was blocking only: it reports only CRITICAL and IMPORTANT findings. Scope: I read every hunk of both files in What changed: the push adds two eval files to the
What I checked:
Spend (not a finding): the added grader runs inside the existing eval case, so it adds no model runs beyond the prepaid usage that case already draws. critical-findings: 0 |
|
claude-review reviewed Code review (incremental): PR #16422 at
|
…ites The case's expected outcome says no .py file is written or edited, and only Write was graded. A no-code-edit grader matches the sibling design cases. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
No related issue: owner decision from a design interview on how planning uses the architecture skills (2026-11-14), recorded outside this repository.
Summary
No planning skill named
/architecture:principles, and only/planning:brainstormnamed/architecture:improve, so a design that changed module structure used neither the module-design vocabulary nor the friction scan./planning:designinvokes/architecture:principles(if enabled) when the work adds, splits, merges or moves a module or its interface, and names/architecture:improve(if enabled) for modules that already exist. Without the architecture plugin it says once what the plugin would add./planning:plannames both skills in its prerequisite check when the plan reshapes existing modules.Fix
plugins/planning/skills/design/SKILL.md: one paragraph in Phase 4 and two rows in the relationship table.plugins/planning/skills/plan/SKILL.md: one clause on the "Which other skills apply?" line.plugins/planning/evals/.Verification
claude plugin eval --scaffold, plugin arm only, 3 runs per case:design-module-split-names-architecture-skills3 of 3,plan-reshape-modules-names-architecture-skills3 of 3. No baseline arm was run: each prompt is a/planning:invocation.plan/SKILL.md) it scored 0 of 3. Its one grader matches the textarchitecture:improve, so it tests that the line is followed, not how well.plugins/planning/tests/interview-defenses.test.sh: PASS=185 FAIL=0;plugins/planning/scripts/repin-digests.test.sh: 23 passed.Scope change
The first head also added a
Later:line to the/planning:interviewround header. That paragraph sits in a section whose digestinterview-defenses.test.shpins, soTest Bashfailed. It is removed from this PR and ships separately with its re-pin.Related
/architecture:principles..changes/planning/; the two touch different files.🤖 Generated with Claude Code