Repository navigation
feat(architecture): add the seam's enabling point, its sense and architecture styles - #16418
Conversation
…styles The module-design vocabulary's Seam entry says it is the module-design sense, lists the marketplace's four other defined senses by file, and adds Feathers' enabling point. The Adapter entry separates it from the Gang of Four Adapter pattern. A new section names modular monolith and vertical slice with their sources. The planning design defaults cite Steve Smith's "New is Glue" under DIP. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
…rases Two regex graders failed one of six correct replies on wording. One judge grader replaces them; the enabling-point and no-write checks stay deterministic. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Lane run report
Failed GitHub API calls
|
|
claude-security-review reviewed Security review: PR #16418 (incremental, since c34062c)I found no security issues. This review covered only the change since What changed since the last review: It rewords documentation and an eval case.
What I checked:
Spend: Nothing new. The eval case's model runs were already noted in the last review, and they draw on prepaid API credits only. critical-findings: 0 |
|
claude-review reviewed Incremental review of What changed since the last review: the list of the marketplace's other senses of "seam" moved out of the plugin's What I checked:
I did not run the eval. Any pass rates the PR states are the author's claims and unverified. Spend: the eval case still uses prepaid model credit on each plugin-eval run, the same as before (up to 10 turns and a 300-second timeout, plus one LLM judge call). Verifier dropped 0 of 0 candidates. |
…e shipped vocabulary The list of the marketplace's four other senses of "seam" shipped to every repository that installs the plugin. It moves to docs/glossary.md. The vocabulary keeps one sentence: this is the module-design sense, and a finding never means a project's other senses. The eval case asks what the shipped text states. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
…grader Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
No related issue: owner decisions from a design interview on the module-design vocabulary (2026-11-14), recorded outside this repository.
Summary
The module-design vocabulary used "seam" and "adapter" without saying which of several senses it meant, and named no architecture style.
docs/glossary.mdgains a seam entry listing the five senses this repository defines, each by its file. That list stays out of the shipped vocabulary, which every installing repository reads.Fix
plugins/architecture/reference/vocabulary.md: the three additions above. It names no file of this repository.docs/glossary.md: the seam entry.plugins/architecture/skills/principles/SKILL.md: two routing rows for the new content.plugins/planning/reference/design-principles.md: one sentence and one source on the DIP line.plugins/architecture/evals/pr-seam-senses-and-adapter-not-gof/: one outcome case.Verification
claude plugin evalon the new case at this head, 3 runs per arm: 3 of 3 passed with the plugin, 0 of 3 without it (the baseline fails the judge grader each time).validate-cases.pyoverplugins/architecture/evals: no FAIL;scripts/check-changelog-fragments.sh --check: valid.Related
/architecture:principlesand this vocabulary file.🤖 Generated with Claude Code