Skip to content

architecture:improve: decide whether the deepening interview loop and hand-off move to shared skills #16962

Open

Description

@kyle-sexton

Problem

#16496 split architecture:improve: the shared lens steps moved to reference/improvement-steps.md and layout moved to architecture:improve-layout. It left two parts unchanged on purpose ("The interview loop and the design hand-off are unchanged", #16496 body). Both still live only in the deepening lens, plugins/architecture/skills/improve/actions/deepening.md (Phase 3 interview loop, Design-It-Twice mode, hand-off to /planning:design). Nothing tracks the deferred part.

Done when

  • A recorded decision says whether the interview loop reuses planning:interview and whether the hand-off moves to the shared steps.
  • Either the change is merged with an eval case on the deepening flow, or the decision to keep both in the lens is recorded in deepening.md or an ADR.

Source: workshop 05 (codebase design) close-out audit.

Activity

  1. added
    needs-triageNot yet classified. Floor until a type and one priority tier are set.
    on Nov 17, 2026
  2. github-actions commented on Nov 17, 2026

    @github-actions
    Contributor

    Size: Medium
    Complexity: Medium
    Uncertainty: Knowable
    Flags: intent
    Blocked by: none
    Blast radius: the architecture plugin's deepening lens (actions/deepening.md), possibly the shared improvement steps and planning:interview, and an eval case; read by anyone running architecture:improve.
    Reversible: yes; revert the merged change, or edit the recorded decision.
    Open questions:

    1. Should the deepening interview loop (Phase 3, including Design-It-Twice mode) reuse planning:interview, or stay in the deepening lens?
      RECOMMENDED: reuse planning:interview only if its contract covers the loop's needs without a lens-specific fork; otherwise keep it in the lens. Basis: judgment; the issue gives no comparison of the two, and a shared skill avoids two copies of the loop.
    2. Should the hand-off to /planning:design move into the shared steps in reference/improvement-steps.md, or stay in the lens?
      RECOMMENDED: move it to the shared steps only if architecture:improve-layout needs the same hand-off; otherwise keep it in the lens and record that choice in deepening.md. Basis: judgment; the split in refactor(architecture)!: share the lens steps and split layout into improve-layout #16496 left it in the lens on purpose.

    I understood this as a request to record a decision on the two parts #16496 left in the deepening lens. It ends with either a merged change plus an eval case on the deepening flow, or a recorded decision to keep both in the lens. I found no duplicate among the open issues and no merged pull request that already covers it.
    To answer, post a comment that starts with this line:

    **Decision recorded.** <answer>
    

    Automated triage. A maintainer reviews it.

  3. melodic-automation-lanes commented on Nov 17, 2026

    @melodic-automation-lanes
    Contributor

    The triage verdict left this issue at needs-owner-decision:

    • flagged: intent
    • held by needs-owner-decision
    • no lanes App verdict comment shows whether an earlier verdict was flagged

    Reason: intent

  4. melodic-automation-lanes commented on Nov 17, 2026

    @melodic-automation-lanes
    Contributor

    Refinement. A read-only run explored this repository, searched its issues and pull requests, and read the allowed docs to draft what follows. On an issue a listed human filed, it counts as the issue's spec once posted, while unedited; it is still model text, so check it.

    Intended outcome: Record a decision in deepening.md or an ADR that the interview loop stays in the deepening lens and the hand-off stays split as it is now, with no code change.

    Related work

    Open questions

    1. Should the deepening Phase 3 interview loop, including Design-It-Twice mode, reuse planning:interview, or stay in the deepening lens?
      RECOMMENDED: Keep it in the lens. The loop is tied to lens state: the agreed-shape and graft-record fields, the exemplar call-site check, the ubiquitous-language curate side effect and the Design-It-Twice fan-out. planning:interview is a large skill with its own lanes, session config and templates, so reuse would need a lens-specific fork. Record the decision in deepening.md. Basis: plugins/architecture/skills/improve/actions/deepening.md:110
    2. Should the hand-off to /planning:design move wholly into reference/improvement-steps.md, or stay in the lens?
      RECOMMENDED: Keep the lens-specific part (status agreed-shape, graft-record, the /planning:design call) in deepening.md. The shared part (freshness re-check, two implementer instructions, multi-candidate landing order) is already in improvement-steps.md. improve-layout already cites the shared Hand-off section, so little remains to move. Record this in deepening.md. Basis: plugins/architecture/reference/improvement-steps.md:101
    3. Is a recorded decision in deepening.md enough, or does the owner want an ADR via architecture:record-decision?
      RECOMMENDED: Record it in deepening.md. If the decision is keep-both, no eval case is needed, since the done-when only requires an eval case when the change is merged. Basis: judgment

    Sources read

    • plugins/architecture/skills/improve/actions/deepening.md:110: Phase 3 interview loop with three groups, side effects, agreed-shape entries; stops at the handoff
    • plugins/architecture/skills/improve/actions/deepening.md:125: Design-It-Twice mode, full process in research/deepening/interface-design.md
    • plugins/architecture/skills/improve/actions/deepening.md:129: Handoff writes agreed-shape and graft-record, then calls /planning:design if enabled
    • plugins/architecture/reference/improvement-steps.md:101: shared Hand-off section with freshness re-check, implementer instructions, multi-candidate order
    • plugins/architecture/skills/improve-layout/SKILL.md:135: layout lens has its own interview and hands off to /planning:design
    • plugins/architecture/skills/improve/SKILL.md:85: lens playbooks cite the shared steps including the hand-off
    • plugins/planning/skills/interview/SKILL.md: exists with lanes, context files and evals; contract not compared in detail

    To answer, post a comment that starts with this line:

    **Decision recorded.** <answer>
    

    Automated refinement by the lanes App. Answer with a comment whose first line is **Decision recorded.**.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    needs-owner-decisionAwaiting a human or maintainer judgment call.needs-triageNot yet classified. Floor until a type and one priority tier are set.

    Type

    Fields

    Work status

    needs-owner-decision

    Priority

    medium

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions