Repository navigation
feat(review): always raise change amplification as an important finding - #16051
Conversation
The code-design criteria and the code-reviewer agent rate change amplification (Shotgun Surgery) IMPORTANT on every surface, never CRITICAL, with every site the one change had to edit as evidence and a /coupling:reduce follow-up when the fix is too large for the change. /planning:plan flags the same shape in its files-affected list. The code-reviewer severity eval now expects IMPORTANT for the PayPal sites. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
…on sites The coupling model already says an entity, its DTO and its mapper for one new field are necessary plumbing, so the review criterion does not count them as sites. Co-authored-by: Claude Fable 5.2 <noreply@anthropic.com>
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
claude-security-review reviewed Security review: PR #16051I read all 9 changed files in full, plus the two deleted eval files. I found no security issues. What the change does. It edits prose review criteria and eval data:
Checks I ran:
Prior findings: none; this lane has reviewed 0 earlier heads, so this was a full review, not blocking only. critical-findings: 0 |
|
claude-review reviewed Code review: PR #16051, head
|
No related issue: owner-decided change to the bundled code-design review criteria.
Summary
Code review now always raises change amplification (one logical change that had to edit several sites in step, in code or Markdown) as an IMPORTANT finding, and
/planning:planflags it at plan time.Fix
plugins/review/skills/quality-gate/context/code-design.md: the Shotgun Surgery row becomes "Change amplification", IMPORTANT on every surface and quality bar, never CRITICAL, with no file-count threshold. It used to be a SUGGESTION raised only when the diff added to an existing set of coordinated edits. A new subsection says what the evidence is (the file and line of every site), what is not a site (a declared registry entry, a generated file, a rename or move, per-layer representation of one change), and that a fix too large for the change becomes a/coupling:reducefollow-up.plugins/review/agents/code-reviewer.md: rates Shotgun Surgery by that row, as it already rates Duplicated Code by its row.code-reviewer-duplicated-code-severityeval: the Shotgun Surgery case now expects IMPORTANT and never CRITICAL.plugins/planning/skills/plan/SKILL.md: "Files affected" flags one logical change spread over many sites and proposes moving the repeated knowledge behind one module first, or records why not.Verification
validate-cases.pyandcheck-matchers.pyreport no new failures.markdownlint-cli2on the changed Markdown: 0 issues.claude plugin eval); CI's lanes cover the repository's suites.Related
plugins/planning/reference/design-principles.md"Deep modules and change amplification" is the design-time definition the plan step points at.plugins/coupling/skills/reduce/reference/coupling-model.mdalready treats per-layer plumbing as not Shotgun Surgery; the criterion follows it.🤖 Generated with Claude Code