Skip to content

docs(upstream): record the feedback-loops close-out decisions - #16947

Merged
kyle-sexton merged 1 commit into
mainfrom
docs/feedback-loops-record-closeout
Nov 17, 2026
Merged

kyle-sexton merged 1 commit into
mainfrom
docs/feedback-loops-record-closeout

Conversation

@kyle-sexton

Copy link
Copy Markdown
Member

No related issue: workshop 06 close-out audit re-run (2026-11-17)

Summary

Brings the public record for the AI Hero Feedback Loops workshop
(docs/upstream/aihero-feedback-loops.md) in line with the close-out decisions that landed after
it was written: the codify planted-violation proof and formatter rung, the shell-lint commit-budget
fix, the bare-wait fixes, the hook rule for ecosystem records, the team skip rule, and the
generic cases #16922 built. Every "this change" and "this record" placeholder now names the pull
request that added the row.

Fix

Verification

  • markdownlint-cli2 on the file: 0 issues.
  • Every table row keeps its section's cell count (6 in the attribution tables, 3 in "Found while
    absorbing").
  • scripts/check-upstream-drift.sh --page docs/upstream/aihero-feedback-loops.md exits 2 with
    "no git pin marker": this record has no pinned git upstream, so the drift check does not cover
    it (a full run skips it).
  • Pre-commit (pre-commit-content, comment-lint), commit-msg and pre-push (check-affected,
    reference-verify, pre-push-content) hooks passed.
  • The diff holds no machine paths, secrets or private-repository references.

Related

🤖 Generated with Claude Code

Bring the workshop 06 record in line with the close-out audit re-run:

- codify: planted-violation proof for never-broken rules and the
  formatter rung (#16930; rule inventory gap #16931).
- commit budget: the shell lint over budget, its parallel fix and the
  pre-push lint-full entry (#16906), and the format-check rejection's
  basis restated.
- parallel hook jobs: the bare-wait fixes (#16895).
- format and lint hooks run only shipped adapters; records run only
  through /toolchain:lint and /toolchain:check.
- new rows: team hooks and the one skip key, the setup-pre-commit
  rejection, the dependency-collision check, the generic cases #16922
  built, and three settled follow-ups.
- every "this change" and "this record" placeholder names #16664 or
  #16916.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kyle-sexton
kyle-sexton marked this pull request as ready for review November 17, 2026 21:03
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 17, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-17T21:05:27.484549Z ed395a0 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

Copy link
Copy Markdown
Contributor

Lane run report

Field Value
Activity pr-refine/fix-docs
Model rung 0
Leg handoff
Run job success
Activity step success
Commits pushed none (read lane)
Run 44175879465

Failed GitHub API calls

Method Path Status
GET /repos/{repo}/git/ref/tags/* 404

@github-actions

Copy link
Copy Markdown
Contributor

claude-security-review reviewed ed395a0ea4fa1bc5d1499b39ef8851a91556bb18: read 1 of 1 changed file(s); 0 finding(s), 0 as inline comments.

Security review: no security issues found

This pull request changes one file, docs/upstream/aihero-feedback-loops.md, which matches the trusted-path glob docs/upstream/**. I read every hunk.

What the change is. It updates a decision record for the AI Hero feedback-loops workshop:

What I checked:

  • Code and configuration: there is none in this diff. No workflow, action, script, manifest, userConfig key, hook, trusted-actor list, token scope, kill switch or merge-hold code changes.
  • Instruction surface: the file is a record of decisions, not a standing instruction (it is not CLAUDE.md, AGENTS.md, a rules file, a skill or agent body, or a hook's allow or block list). It removes no guardrail. The reworded "Format and lint plugins" row describes a narrower rule: a repository's .claude/ecosystems/<id>.yaml command runs only when a person asks for it, never from a hook. The reworded format-check row keeps its rejection and only changes the reason it gives. The new team-hooks row says there is no per-person skip and that guardrails block-no-verify still blocks the other skips. Nothing it describes widens what runs unchecked. The protected-class list in the instruction exception register was not consulted, because nothing in this diff deletes or softens an instruction.
  • Sensitive content: no secrets, tokens, machine paths or private-repository references. Every link points to a public GitHub docs page or to this repository's own pull requests and issues.
  • PR context: the description has no embedded text telling the lane to pass the PR, skip a check or drop a finding.

There are no prior findings (0 earlier heads reviewed), so this is a full review, not blocking only.

critical-findings: 0

@github-actions

Copy link
Copy Markdown
Contributor

claude-review reviewed ed395a0ea4fa1bc5d1499b39ef8851a91556bb18: read 1 of 1 changed file(s); 0 finding(s), 0 as inline comments.

Code review: no findings.

This change touches one file, docs/upstream/aihero-feedback-loops.md. It only edits documentation. It records the feedback-loops close-out decisions and replaces the "this change" and "this record" placeholders with the numbers of the pull requests that added each row. I read every hunk in the diff.

What I checked against the repository at head:

  • Anchors: both new links resolve to real headings in docs/contracts/check-placement/README.md: #hooks-run-the-shipped-adapter (L182) and #the-skip-key-checksskipmissing (L225).
  • Commit-budget and check-speed figures: these match the Duration budgets and Per-check timings tables:
    • the 10 s commit budget
    • 22.0 s for the lint before the change and 2.99 s after, on 44 files
    • 11.8 s for lint-full at pre-push
    • 96.3 s for the whole pre-commit set
    • the order of the fixes: identical copies linted once first, then parallel lanes
  • Hook rule for ecosystem records: the "records never run from a hook" wording matches the contract at L189-L193.
  • Skip key: the checks.skipmissing row matches the contract at L225-L240.
  • prove-check.sh --plant: the flag exists in plugins/corrections/scripts/prove-check.sh.
  • setup-pre-commit rejection: this agrees with the "Not adopted" entry in docs/upstream/mattpocock-skills.md (L350).

Not checked: the PR body's verification steps (markdownlint, cell counts, the hook runs) are the author's claims. I did not run them. The pull request numbers that replace the placeholders, which the author says came from git blame, are also unconfirmed.

Closing issue: none. The PR body says "No related issue", so there are no acceptance criteria to check.

Embedded text: none of the PR context or prior-findings text tries to steer the review.

Prior findings: none. This is the lane's first review of this pull request, and it is not blocking only.

Loosened-check verdict: fail (default; the prompt gave no resolved setting); patterns: 0. This change edits no check, test, threshold or CI setting.

Verifier dropped 0 of 0 candidates.

@kyle-sexton
kyle-sexton added this pull request to the merge queue Nov 17, 2026
Merged via the queue into main with commit f054e1b Nov 17, 2026
78 checks passed
@kyle-sexton
kyle-sexton deleted the docs/feedback-loops-record-closeout branch November 17, 2026 21:49
@github-actions github-actions Bot added the merge-path: owner-agent Post-merge accounting record (README.md, Merge paths) label Nov 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge-path: owner-agent Post-merge accounting record (README.md, Merge paths)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant