Repository navigation
feat: make data sources, test scope and commands work for any repo - #16922
Conversation
- app-control: a data source read with a credential names its variable and a consumer-supplied read-only grants command; drive ready runs it and caps a source without a passing record at attended. - app-control: a data source may record its data category, readers and the review that decided them; map asks before a level above never. - ecosystem-commands 1.6.0: optional test-changed-cmd, a change-scoped test command over <files>; toolchain:check runs it for a change and test-cmd under all; setup drafts it from the repo's own runner. - toolchain:setup drafts command keys from the repo's own task runner or wrapper scripts before the bundled default, in any ecosystem. - mcp-tools audit: info-level C21, a destructive tool has a preview or dry-run counterpart that runs the same checks and changes nothing. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A source that offers no scope control records grants: full-user-access. It stays capped at attended, like a source with no grants record, and drive ready names the reason. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Lane run report
Failed GitHub API calls
|
|
claude-security-review reviewed Security review (incremental, blocking only): no findingsThis review covers only the change since What changed: C21 is an info-level audit criterion that asks whether a destructive tool has a preview counterpart. It now applies only when a tool's Why it is not a security finding:
The fix is the one the settled thread on this file asked for, and it was answered by the owner. critical-findings: 0 |
|
claude-review reviewed Code review: PR #16922 (incremental, blocking only)Scope: what changed between Result: no new findings. The commit fixes the one finding from the last review (C21 flagged read-only tools).
Settled thread: the owner resolved that thread with a reply stating the fix. I have not raised it again. Not checked:
Loosened-check verdict: fail (default; the job supplied no settings); patterns: 0. The changed row narrows which tools C21 flags. It is not a loosening, because the tools it stops flagging are ones the spec says are not destructive. Verifier dropped 0 of 0 candidates. |
…rion C21 resolved a missing destructiveHint to true through C13's default, so every read-only tool was reported as lacking a preview counterpart. The MCP ToolAnnotations schema counts destructiveHint only when readOnlyHint is false; C21 now requires readOnlyHint to be not true. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
No related issue: workshop 06 close-out, owner decisions Q762-Q766 (2026-11-17)
Summary
Five owner-approved changes so the app-control, toolchain and mcp-tools skills work in any consumer repository, whatever its stack. Stack specifics come from the consumer repository at run time, never from a per-stack example or default.
Fix
sourcesentry read with a credential names the credential's variable (credential) and a consumer-supplied read-onlygrantscommand./app-control:mapasks for both with the read level;/app-control:drive readyruns the command where the entry's level allows and reports the exit. A source that offers no scope control recordsgrants: full-user-access: it has no read-only grant to show. That source, and one with a credential and no passinggrantsrecord, is capped atattended, and ready names the reason. The contract states the basis (a read-only rule held only in the agent's tool can be bypassed, so the guarantee rests on the store's own grants) and points at ADR 0086.datafield records the data category a source exposes, who may read it, and the review that decided both. The control skill records the review; it does not perform it. Map asks for it before any read level abovenever; ready lists it.test-changed-cmdkey, a change-scoped test command over<files>(also arequireskey)./toolchain:checkruns it for a change and the fulltest-cmdunderallor with no changed files; a repository's CI calls the same recorded command./toolchain:setupdrafts it from the repo's own test runner, or through/discovery:researchwhen the repo has none. No bundled default changes.destructiveHintis true has a preview or dry-run counterpart (a tool or a mode) that runs the same checks and changes nothing. It points at the--dry-runtrait in the app-control control-skill contract. Criteria counts move from 20 to 21 and from eight categories to nine./toolchain:setupdrafts each command key from the repo's own task runner or wrapper scripts before the bundled default, in any ecosystem. This general rule replaces the one-ecosystem scripts special case, which becomes one instance of it. No new key for other verbs.Verification
scripts/validate-plugins.sh --onlyfor app-control, toolchain and mcp-tools: all manifests and the catalog validated.docs/contracts/ecosystem-commands/examples.test.sh: PASS=10 FAIL=0.scripts/check-contract-clause-coverage.py: passed.scripts/check-standards-contract-bump.sh origin/main: no bumps required.scripts/check-changelog-fragments.sh --check-required origin/main: every fragment-mode plugin changed (3) has a fragment. No eval or test pins the changed text; no eval was touched.Related
🤖 Generated with Claude Code