Repository navigation
feat: land the feedback-loops close-out decisions - #16916
Conversation
- testing:diagnose reads each environment's data sources through /app-control:drive ready when the failing test drives a running app. - playwright checks state on the DOM and uses pixels only for a visual change. - pull-request evidence: regulated-product captures use synthetic data only. - mutation-testing writes each demonstrated equivalent mutant with its demonstration to a Declined candidates section of the findings file; detector-findings contract 3.10.0 allows that unparsed section. - corrections:codify names past sessions, through session-flow:audit-sessions, as a count source. - docs/upstream records the decisions and corrects stale rows. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…ording - testing:diagnose frames what a data source returns as data, per the untrusted-content contract. - evidence guidance states that no step checks a capture's image content. - codify section 1 no longer counts its sources as two places. - detector-findings adopter row and persist-findings name the Declined candidates section. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Lane run report
Failed GitHub API calls
|
|
claude-security-review reviewed Security review: PR #16916 (head f3b69bc)I found no security issues. I read every hunk of all 16 changed files. The pull request changes only prose and records: skill bodies, a contract doc, upstream records, changelog fragments and one eval case. It has no code, workflow, manifest or trust-control change. What I checked:
This is the first review of this pull request (blocking only: no). No plugin manifest is touched, so there are no manifest lines. I found no billing or cost change. critical-findings: 0 |
|
claude-review reviewed Code review: no findings. I read every hunk of all 16 changed files. The pull request only changes docs and skill text, plus changelog fragments and one eval case. What I checked against the head tree:
Other notes:
Verifier dropped 0 of 0 candidates. |
No related issue: workshop 06 close-out, owner decisions Q752-Q760 (2026-11-17)
Summary
Builds the owner's approved close-out decisions from the Feedback Loops workshop (AI Hero cohort 005) and corrects the public upstream record.
Fix
/testing:diagnosereads each environment's data sources through/app-control:drive readywhen the failing test drives a running app, at each source's read level, framed as untrusted data (plugins/testing/skills/diagnose/context/investigate.md)./playwright:playwrightchecks state (presence, counts, text, enabled or checked) on the DOM and uses pixels only for a visual change (plugins/playwright/skills/playwright/SKILL.md, Conventions).plugins/source-control/skills/pull-request/reference/evidence.md). Image leak scanning is not built here; it is #16908./mutation-testing:audit --persist-findingswrites each demonstrated equivalent mutant, with its demonstration, to a## Declined candidatessection the fix action does not parse (context/persist-findings.md, SKILL.md "Record accepted arid mutants"). The detector-findings contract allows that section (3.10.0, minor, additive). A new legacy eval case covers it./corrections:codifysection 1 names past sessions as a count source, through the existing/session-flow:audit-sessionscorrection-lens route. No new action.docs/upstream/aihero-feedback-loops.md): tests stay in CI (measured 90.7-145.7 s per push, over the 60 s pre-push budget); format and lint unit merged; environment data sources merged; run lessons reachmap refresh; new rows for the pre-commit formatter decline, the DOM rule, regulated captures, equivalent calls, codify's past-session route and the CodeQL decline; work-specific uses recorded as cases the skills handle generically.docs/upstream/aihero-review.mdpoints to the one-rules-file batch exception.Verification
scripts/validate-plugins.sh --only "testing playwright source-control mutation-testing corrections": pass.scripts/check-changelog-fragments.sh --check-required origin/mainand--check: pass.scripts/check-changelog-parity.sh --check,--check-order,--check-preserved origin/main: pass.scripts/check-contract-clause-coverage.py,scripts/check-as-of-recheck.sh: pass.plugins/mutation-testing/evals: no FAIL.testinghookstest-weaken/test-scanandjudge-calibration/metrics.test.sh, which fail identically on the main checkout (mise install output leaks into the captured output).Related
Follow-ups
plugins/mutation-testing/skills/audit/templates/report.md:3says Phase 6 persists the report verbatim, which disagrees withcontext/persist-findings.md, which writes the findings-file shape.🤖 Generated with Claude Code