Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions .changes/corrections/feat-feedback-loops-closeout-d6c3f8a4.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
---
bump: patch
---

### Changed

- `/corrections:codify` names past sessions as a count source: a correction
`/session-flow:audit-sessions` finds in an earlier session reaches codify through that skill, and
the sessions it names count as occurrences.
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
---
bump: minor
---

### Added

- `/mutation-testing:audit --persist-findings` writes each demonstrated equivalent mutant, with its
demonstration, to a `## Declined candidates` section of the findings file, which the fix action
does not parse. The suppression record still never holds an equivalent mutant.
8 changes: 8 additions & 0 deletions .changes/playwright/feat-feedback-loops-closeout-5e08b4d1.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
---
bump: patch
---

### Changed

- `/playwright:playwright` checks state (presence, counts, text, enabled or checked) on the DOM
and uses a screenshot only for a visual change.
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
---
bump: patch
---

### Changed

- `/source-control:pull-request evidence`: screenshots and recordings of a regulated product show
synthetic data only, since no step checks a capture's image content for real records.
8 changes: 8 additions & 0 deletions .changes/testing/feat-feedback-loops-closeout-3c9a71e2.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
---
bump: minor
---

### Added

- `/testing:diagnose` reads each environment's data sources through `/app-control:drive ready`
when the failing test drives a running app, each source only at its read level.
8 changes: 8 additions & 0 deletions docs/contracts/detector-findings/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,14 @@ Notable changes to the detector-findings contract (SemVer). Changing a producer-
the coexistence obligations, or an enforceability verdict is a major bump; additive guidance or a new
adopter row is a minor bump; docs-only clarification is a patch.

## [3.10.0] - 2026-11-17

**Minor, additive.** "A candidate that is not a finding" lets a producer write the evidence for
each declined candidate, such as a demonstration, in a `## Declined candidates` section after
`## Surfaces`, one line per candidate. The fix action does not parse it, and the per-rule count in
`## Surfaces` is unchanged. `mutation-testing:audit` writes each demonstrated equivalent mutant
there. No producer-owned field's rule, coexistence obligation, or enforceability verdict moves.

## [3.9.1] - 2026-11-14

**Patch, docs-only.** The shared-emitter decision's trigger and the
Expand Down
18 changes: 13 additions & 5 deletions docs/contracts/detector-findings/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -573,12 +573,20 @@ failure to avoid:
it, which is the same rule that keeps a reviewer's reasoning out of a `Finding` cell. Counts also
keep the section short enough to stay one line per surface, and are the form a trend across runs
can be read from at all.
- **Where a decline's evidence may go.** A producer whose decline evidence is something a reader
must be able to re-check, such as a demonstration, may write it in a `## Declined candidates`
section after `## Surfaces`, one line per declined candidate:
`- <rule id>, <Location>: <the evidence its crosswalk row requires>`. The fix action does not
parse that section, so nothing in it is applied, and the `## Surfaces` count stays the trend.
The evidence is the artifact; the argument for it still goes in the human-facing report.
- **No evidence, no decline.** A rule that may decline states in its crosswalk row what evidence a
decline requires. A candidate declined without that evidence is not declined. It emits.
- **No new field, and that is the decision.** A column or section for dispositions would push a
per-run judgment into the shape the fix action parses, where every consumer would have to learn to
ignore it; a separate file type would be structure with no reader. The disposition belongs to the
**rule**, so it is declared once in the crosswalk and only its count is per run.
- **No new field in the parsed shape, and that is the decision.** A column or parsed section for
dispositions would push a per-run judgment into the shape the fix action parses, where every
consumer would have to learn to ignore it; a separate file type would be structure with no
reader. The disposition belongs to the **rule**, so it is declared once in the crosswalk and only
its count is per run. `## Declined candidates` sits outside the parsed shape, as
`## By dimension` does.

## Coexisting with other producers

Expand Down Expand Up @@ -729,7 +737,7 @@ the bar in full.

| Producer | Status | Notes |
|---|---|---|
| `mutation-testing:audit` | Conforming, opt-in. Remedies not pinned (3.0.0, grandfathered) | The first detector pilot. Persists surviving mutants behind `--persist-findings`; bare invocation still reports and stops. Maps each Phase 4 verdict class to one crosswalk rule and emits `Confidence: high` only. **Its rule selection is a fresh-context reviewer's judgment, not a computation**, so it is the worked case for the fail-safe-toward-emitting criterion rather than an exception to it. It has **two** withholding boundaries and both fall through to the emitting `unclassified` rule: an equivalence verdict that cannot cite its demonstration, and an aridity call whose proposed suppression entry does not bind a node kind from its enumerated vocabulary and name the behavior the suite deliberately leaves unasserted. A wavering judgment can therefore add a row but never silently remove one. **Both bars sit at classification rather than at persist time**, which is what makes the fall-through one answer per survivor instead of a report and a findings file that can disagree, and it means the bar binds a run that never persists, where an unevidenced withholding claim is read by a human rather than by the relay. Omits `tier:`, `## By dimension`, and `## Unparsed` as a detector with no analogue for them; keeps `## Surfaces`, which is the whole payload of a run that examined mutants and found nothing, and where its declined-candidate counts go. Its remediation is off-site, the covering test rather than `Location`, so every row it emits names the target in `Action` and the consumer surfaces rather than applies. It declares no remediation owner and is unaffected by that disposition: its `Auto-applicable` cells keep the forms they already had, `No, <reason>` on its two emitting rows and `Not applicable, no row` on the two that emit none, and off-site is decided first in any case. **Remedy assertions (3.0.0): none.** What its eval `expected_output` pins is the off-site `Action` shape, that the cell names the covering test and states the remediation site is not the row's `Location`. That is a claim about where a fix goes, not about the remedy any rule offers in the scope it fires in, and it is a model-graded expectation rather than a check a run fails. Grandfathered, and the debt is one assertion per emitting rule rather than a redesign. |
| `mutation-testing:audit` | Conforming, opt-in. Remedies not pinned (3.0.0, grandfathered) | The first detector pilot. Persists surviving mutants behind `--persist-findings`; bare invocation still reports and stops. Maps each Phase 4 verdict class to one crosswalk rule and emits `Confidence: high` only. **Its rule selection is a fresh-context reviewer's judgment, not a computation**, so it is the worked case for the fail-safe-toward-emitting criterion rather than an exception to it. It has **two** withholding boundaries and both fall through to the emitting `unclassified` rule: an equivalence verdict that cannot cite its demonstration, and an aridity call whose proposed suppression entry does not bind a node kind from its enumerated vocabulary and name the behavior the suite deliberately leaves unasserted. A wavering judgment can therefore add a row but never silently remove one. **Both bars sit at classification rather than at persist time**, which is what makes the fall-through one answer per survivor instead of a report and a findings file that can disagree, and it means the bar binds a run that never persists, where an unevidenced withholding claim is read by a human rather than by the relay. Omits `tier:`, `## By dimension`, and `## Unparsed` as a detector with no analogue for them; keeps `## Surfaces`, which is the whole payload of a run that examined mutants and found nothing, and where its declined-candidate counts go; each demonstrated equivalent call goes, with its demonstration, in `## Declined candidates`. Its remediation is off-site, the covering test rather than `Location`, so every row it emits names the target in `Action` and the consumer surfaces rather than applies. It declares no remediation owner and is unaffected by that disposition: its `Auto-applicable` cells keep the forms they already had, `No, <reason>` on its two emitting rows and `Not applicable, no row` on the two that emit none, and off-site is decided first in any case. **Remedy assertions (3.0.0): none.** What its eval `expected_output` pins is the off-site `Action` shape, that the cell names the covering test and states the remediation site is not the row's `Location`. That is a claim about where a fix goes, not about the remedy any rule offers in the scope it fires in, and it is a model-graded expectation rather than a check a run fails. Grandfathered, and the debt is one assertion per emitting rule rather than a redesign. |

| `testing:audit` | Conforming, opt-in. Remedies partly pinned, 8 of 13 (3.0.0; three grandfathered, the two config rules owed in full, the eight later rules pinned positive and negative in each scope they fire in) | The first static Tier 1 detector, and the contract's first fully mechanical rule set: selection is a deterministic token/structure scan with no execution, so the fail-safe-toward-emitting criterion holds across both of its layers. Its three original test-body rules carry no withholding verdict at all, and the one uncertain case among them (a deliberate interaction-style test matching `rule-mock-only-oracle`) still emits, with `Confidence` omitted per the high-or-omitted rule. Its two Playwright runner-config rules do withhold, and every boundary is stated-evidence: `spread-undecidable` requires a depth-1 spread token, `variadic-undecidable` a second `defineConfig` argument, `key-below-top-level` the key read below depth 1, `key-set` the guard read as `true` or as an expression, `retries-not-configured` a complete read of an anchored config object carrying no counted `retries` at all or none but literal `0`s, and `cant-fail-ok:` the annotation itself. Each requires a token present in the file, so nothing is withheld on absence alone, and every decline is counted per rule in `## Surfaces`. A config whose object literal cannot be anchored is judged by neither rule: it is reported in the denominator as enumerated and not examined, the same coverage statement the test-file counts already make about a file of another ecosystem. Persists behind `--persist-findings`; bare invocation reports and stops. Leads every `Finding` cell with the qualified rule id and the fired threshold in the run's own values; `Confidence` is `high` on the three deterministic-defect rules (`rule-zero-assertion`, `rule-recomputed-expectation`, `rule-inert-assertion`) and omitted on `rule-mock-only-oracle`, both config rules and the seven other later rules, never `low`. `Location` is repo-relative (computed through git's own prefix under a narrowed scan root) and is the remediation site, since the repair belongs in the flagged test, or in the flagged config for the two config rules, but every row is judgment repair, the oracle a behavior deserves on the test-body rules and the team's flaky-tolerance or `only`-guard policy on the config rules, so none is auto-applicable. It declares **no** remediation owner, and that is correct rather than an omission: no skill owns choosing the assertion a behavior deserves or the runner policy a team wants, so its cells keep the plain `No, <reason>` form and Step 4's judgment fence surfaces the rows, exactly as before. Omits `tier:`, `## By dimension`, and `## Unparsed`; keeps `## Surfaces` with per-rule declined-candidate counts, stating honestly that the recomputed-expectation rule's candidate assertions are not tallied v1 rather than inventing a number. A deliberate case is declined at selection by an in-file `cant-fail-ok: <reason>` annotation, the rules' stated decline evidence, counted in `## Surfaces`, which is a recorded decision at the site it governs (the test for the body rules, the whole file for a Playwright config, on the repo's incumbent test-gate annotation shape), not a suppression of an emitted finding, so the finding-suppression home is not in play. Its `--check` mode is the fail-closed gate the liveness contract's fail-loud limb asks of a gating form: findings of the gating rules exit 1 (`rule-conditional-assertion` and `rule-inert-assertion` among them; the config rules only under `--strict`, one switch that gates them with `rule-mock-only-oracle`, and a tree of configs with no test file reports them without gating or persisting them); an unread input, a dead engine, or a scan that examined nothing exits 2 rather than passing. **Remedy assertions (3.0.0): 8 of 13.** The eight rules added later, report-only but for `rule-inert-assertion` and `rule-conditional-assertion`, which gate `--check` (`rule-inert-assertion`, whose remedy is scoped per language, `rule-constant-restatement`, `rule-source-text-read`, `rule-conditional-assertion`, whose C# remedy adds the skip routes, `rule-recomputed-derived`, `rule-snapshot-only`, `rule-weak-oracle`, and `rule-throw-only-oracle`, which fires only on C# and is held apart from the weak-oracle remedy there) are pinned positive and negative in every scope they fire in. For the first five, `action_of()` carries five distinct remedy strings and `cant-fail-scan.test.sh` matches none of them as a remedy pinned to the rule and the scope it fires in; its only `Action` assertions are on the consumed table header and on the `1.52` version floor inside the flaky remedy, which is the expected-token match 3.0.0 names as passing on the defect the bar exists for. No negative assertion either, so nothing holds a remedy out of a scope it would not work in, and the `mock-only-oracle` remedy is still the one that most needs it among the three test-body rules, since it is the rule whose defect-hood is uncertain and whose advice is therefore conditional. Those three are grandfathered. The two config rules land after 3.0.0 and are held in full, so their shortfall is a debt recorded here rather than a clause covering them, and it is one assertion per rule per scope rather than a redesign. |

Expand Down
Loading
Loading