Repository navigation
feat(plugin-profiles): one-pane /plugin-profile picker, readable preview and a No profile choice - #16759
Conversation
…ile choice The preview and profile list log one line per call, since $.ui.log draws one line, and count the plugins left alone; the CLI is passed this session's id so the confirm does not list it among other sessions; the closing line drops its doubled prefix and names left-loaded plugins only when there are some; after Apply it says to send a message or run /reload-plugins, since no event fires after a local command. The picker gains No profile, which clears the folder's profile behind the same preview, confirm and reload. Refs: #16747 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015XWwmeiHDDb7KAyHDYWQ2G
…file /plugin-profile opens a focused pane holding a Select of every profile and No profile, with a Cancel button. Mobile gets a Button per entry, since a mobile app may draw nothing for a Select; where no pane can be placed the paged question dialog stays as the fallback. The entries live in $.state so the pane's drawing reads them. Refs: #16747 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015XWwmeiHDDb7KAyHDYWQ2G
|
Owner of this pull request: the hub session "Plugin Presets", which runs the plugin-profiles work for #16747. It waits on the ready gates and CI, and then on the owner trying /plugin-profile in a live session before the profiles rollout. The pane picker has only been exercised through claude plugin test, not clicked through interactively. |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 77e09b5667
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Lane run report
Failed GitHub API calls
|
|
claude-security-review reviewed Security review: PR #16759, incremental (77e09b5 → 83386c0)I found no security issues. I read every hunk of all 6 files listed in Scope. None of the changed files match a trusted path. None is a plugin manifest, trust control, merge hold, workflow or instruction-surface guardrail. What I checked:
Spend: none beyond the existing run. critical-findings: 0 |
|
claude-review reviewed Code review (incremental, blocking only): PR #16759,
|
…ding, runnable left-alone hint clear --dry-run --json reports whether a profile is recorded, the one-session profile the running session keeps, and the lines, so the mod no longer matches the tool's wording, and a clear in a session started with a one-session profile says the session keeps it instead of claiming it loaded the user and project settings. The mod preview's left-alone hint is now a runnable command, and the unread untouched array is gone. Refs: #16747 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015XWwmeiHDDb7KAyHDYWQ2G
Closes #16747
Summary
/plugin-profilewas hard to read in a live session (Claude Code 2.1.326, plugin-profiles 0.3.0). This PR fixes the seven defects the owner saw:Selectof every profile plus No profile, with a Cancel button. The owner chose this shape (option A) on 2026-11-17.plugin-profiles:prefix. The prefix is gone./reload-plugins.Fix
hooks/register.tsxopens a pane withfocusandcloseOnEscape, then shows today's preview and Apply/Cancel unchanged.Buttonper entry instead of theSelect. Basis: the mods reference bundled with 2.1.326 says "a mobile app that does not say it draws Input or Select shows nothing for it".$.ui.ask.$.state(picker), so the pane's drawing reads them.$.ui.log"Appends one line to the transcript" and the terminal draws its first 2000 characters (2.1.326 mods types). So each line is its own call.profiles.mjs apply --dry-run --jsonnow counts the left-alone plugins in its lines and returns them as anuntouchedarray.CLAUDE_CODE_SESSION_IDit is given, but the mod's$.process.runnever passed one. The mod now passes$.session.id().$.ui.logtext, since the engine adds the plugin name itself.profiles.mjs clear --for folder --dry-run, thenclear --for folder --yes, then reloads at the turn end. The CLI stays the one place that decides what a clear does./reload-pluginsdrops an earlier profile's plugins still loaded.Verification
claude plugin test plugins/plugin-profiles: 26 pass, 0 fail.register.tsxand passes now.node --test plugins/plugin-profiles/scripts/profiles.test.mjs: 84 pass, 0 fail, including a new case for the counted left-alone line.claude plugin validate plugins/plugin-profilespasses. FourTS2532warnings remain onw.asks[0]lines of the test file.claude -pwith stream-json input, a throwaway folder, local commands only.adhd@melodic-softwarein.claude/settings.local.jsonbetween three/reload-pluginsruns gave 87 plugins / 334 skills, then 86 / 332 with it off, then 87 / 334 with it back on./reload-pluginsunloads a plugin switched off mid-session and loads one switched on. This matches the plugin commands reference: "Pending changes are plugins you installed, updated, enabled, disabled, or edited on disk"./reload-pluginsor the next session start, not only the next start.claude plugin test's mount.Related
/plugin-profile.🤖 Generated with Claude Code
https://claude.ai/code/session_015XWwmeiHDDb7KAyHDYWQ2G