Repository navigation
fix(plugin-profiles): answer /plugin-profile at once and draw the picker as rows - #16827
Conversation
…ker as rows The command.run hook awaited the person's pick, a plain promise, so it overran the hook's 10s budget (mods types HookBudget.ms 10_000; only a $ call's time is free) and its outcome text never printed. The command now opens the pane and answers; the pane's row press runs the preview, confirm and write and logs the outcome. Where no pane can be placed it still pages through $.ui.ask, whose time is free. The pane draws a row per profile and No profile on every surface, with the whole description revealed on hover (BoxProps.hover) and the focused row's under the list, tracked from ui.focus. profiles.mjs counts the plugins left on until the next apply instead of naming the switched-off list again; the mod's closing and in-force lines count them too. status and clear read a record from another copy's data folder (a --plugin-dir copy writes plugin-profiles-inline), so clear no longer says nothing is recorded while the settings file holds its entries. Refs: #16818 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015XWwmdFGUAZ9XpJTmCmKhN
|
Owner: the control-hub session "Plugin Presets" watches and merges this PR. It does not merge before the owner has tried the picker in a live session (see Not delivered). |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
claude-review reviewed Code review: PR #16827, plugin-profiles picker fixes (refs #16818)I read all 7 changed files in full. The PR does four things:
The Finding (1, inline): the hover reveal at Closing issue: the PR context has no closing-issue section. The PR says "Refs: #16818" and leaves the issue open on purpose. So no acceptance criteria were checked, and I did not read #16818's done-when lines from the issue itself. Loosened checks: the prompt has no Spend: none. The PR changes no workflow, model or lane settings. Verifier dropped 0 of 1 candidates. |
|
claude-security-review reviewed Security review: PR #16827 (
|
Refs: #16818
Summary
Fixes the five
/plugin-profilepicker defects the owner saw in a live session after #16759 merged (#16818). This PR does not close the issue because the owner's live try is still open (see Not delivered).Fix
/plugin-profilenever overruns the hook budget, and every outcome line printscommand.runopens the pane and answers at once. The row press runs the preview, confirm and write, then$.ui.logs the outcome line the command used to return. Basis: mods types 2.1.326,HookBudget.ms: 10_000"from its call to its return"; "A$call's time never counts against the calling hook's budget". The old hook awaited a plain promise, which is not a$call. Where no pane can be placed, the paged$.ui.askpath stays inside the command, because that wait is a$call.display: "none"Box withhover: { display: "flex" }that carries the whole description (typesBoxProps.hover). Aui.focushook stores the focused row in$.state(focused), and the pane draws that row's whole description under the list. The pane is still a$.ui.openpane, so it can still be dragged.profiles.mjspreviewLines prints "Left on until the next apply (N): every plugin it switches off" (or "K of the plugins it switches off, plus …") in place of the repeated ids. The mod's closing and in-force lines say "The N plugins it switches off stay loaded …".status,clear,applyand launch defaults read a settings file's record from this copy's data folder first, then from any otherplugin-profiles*data folder, so an installed copy finds the record a--plugin-dircopy wrote underplugin-profiles-inlineand clears it. Basis: profiles.mjslocateplaces an inline copy's data inplugins/data/plugin-profiles-inlineand an installed copy's inplugins/data/<plugin id>, so each copy saw only its own records.Verification
claude plugin test plugins/plugin-profiles: 33 of 33 pass. Run against the mergedregister.tsxandtypes/index.d.ts, all 8 new Fix the /plugin-profile picker pane as seen in a live session #16818 cases fail (the answer-at-once case reads "still waiting", the pane cases time out at 5000 ms). The cases changed for the new flow fail there too.node --test --test-concurrency=4 plugins/plugin-profiles/scripts/profiles.test.mjs: 87 of 87 pass. Against the mergedprofiles.mjs, the new clear-across-copies case and the reworded Left-on case fail.claude plugin validate plugins/plugin-profilespasses. Its 4 TS2532 lines are thew.asks[0]warnings in the test file that existed before Make the /plugin-profile picker and preview readable in a live session #16747.claude plugin testcannot press keys or move the pointer. The hover case checks the drawn tree (the hidden Box and itshover), and the focus case raisesui.focusin the shape the engine sends.Not delivered
--plugin-dir /home/<user>/worktrees/melodic-software-claude-code-plugins-fix-16818-plugin-profile-picker/plugins/plugin-profiles. No CI job runsclaude plugin test(#16816).Related
🤖 Generated with Claude Code
https://claude.ai/code/session_015XWwmdFGUAZ9XpJTmCmKhN