Repository navigation
feat(plugin-profiles)!: switch plugin sets by profile and remove the core bundle - #16483
Conversation
…mmand line Adds the plugin-profiles plugin (on by default) with its engine and the always-on and build profiles. scripts/profiles.mjs applies a profile to a folder's local settings, user settings or a one-session --settings file after a preview and a confirm, checks the required prerequisites of each plugin it switches on, writes only enabledPlugins and skillOverrides through a hash-checked temp-file rename, records the values it replaced, and clear restores them. Refs #16429 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015XWwmd6RuLMb2eXqV5uoEJ
…ep repository profiles out of user settings Declares the claude CLI in prerequisites.json, registers the lib/plugin-options.mjs cluster now carried at the same path by two plugins, separates version from description in plugin.json, and reads no repository profile when applying the initial profile, since that writes user settings. Refs #16429 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015XWwmd6RuLMb2eXqV5uoEJ
Profiles from plugin-profiles replace the fixed core bundle, so core leaves the catalog in the same release that brings them. - Delete plugins/core/ and its marketplace.json entry; regenerate docs/catalog.md. - Drop the validator's core bundle check and its test cases. - Drop core from scripts/fragment-plugins.txt: a removed plugin has no releases left, and the fragment gate otherwise asks for a core fragment. - Point the intake-triage install fixture at plugin-profiles. - Correct the dependencies row of docs/plugin-philosophy.md. - Note the removal in the plugin-profiles changelog fragment. BREAKING CHANGE: core@melodic-software is no longer published. Installed copies keep working until uninstalled; drop its enabledPlugins entry and apply a profile instead. Refs: #16436 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015XWwmd6RuLMb2eXqV5uoEJ
Add discovery, planning, interface-design, review and harness-upkeep beside always-on and build, each with a description line, members from the hub lifecycle scan. The check action reads every profile level through the one profile parser: it fails on a shipped id missing from the catalog, an id under another marketplace (naming the fix), a missing description, an exclude naming an always-on member, and interface-design lacking a planning member; it reports user and repository ids that are not installed and installed plugins no profile names. scripts/check-plugin-profiles.sh runs it in the Check Catalog job. Refs #16435 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015XWwmd6RuLMb2eXqV5uoEJ
…mbering A SessionStart command hook (exec form, node) runs status --session-start: it names the folder's profile, entries that differ, plugins installed since the apply, an unfinished switch and the surface, reads installed plugins from disk without a nested claude, and prints nothing in a folder with no applied profile. lib/surface.mjs detects the surface from CLAUDE_CODE_REMOTE and CLAUDE_CODE_ENTRYPOINT: VS Code and Desktop refuse a one-session apply with the folder offer, cloud sessions report that profiles do not apply and write nothing, and an undetected surface allows the folder level only. A one-session apply and status say to pass --settings again on resume. The remember_folder_profile option (default true): when false a folder apply is refused and status reports the initial profile, naming a folder record as not in force. Refs #16432 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015XWwmd6RuLMb2eXqV5uoEJ
…gin-profile The mod answers /plugin-profile with a picker, the apply --dry-run preview and a confirm, all without a model turn. It writes the on entries, runs /reload-plugins once at the end of the next turn, then writes the off entries, completing the off-pending record; a switch enabling an MCP or language server plugin names it before asking. It runs the CLI as a process and imports no lib/ code. The CLI gains list [--json], apply --dry-run --json, and refuses --defer-off in a one-session profile. Refs: #16433 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015XWwmd6RuLMb2eXqV5uoEJ
…nonical tsconfig Moves the /plugin-profile entry into the branch's one changelog fragment, copies the registered tsconfig.json byte for byte, and fixes a spelling the typos gate refuses. Refs: #16433 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015XWwmd6RuLMb2eXqV5uoEJ
… only on yes Add /plugin-profiles:profile with apply, status, clear, check and a guided setup that inventories plugins and skills, reads local usage history, asks about the user's work and each hook-shipping plugin, and proposes profiles to save. Every write is previewed with --dry-run and runs with --yes only after the user's yes. The CLI gains usage (Claude Code's own skill and plugin counts, or no history), save (a user or repository profile file, printed first) and install (user scope, known marketplaces only, never for a plugin only a repository profile names, then off at user level unless the initial profile includes it); inventory lists each plugin's skills. Evals for setup and status are added, validated, not run. Refs: #16434 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015XWwmd6RuLMb2eXqV5uoEJ
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015XWwmd6RuLMb2eXqV5uoEJ
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 574b7c86c5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Give each Node suite a sibling .test.sh wrapper, the convention scripts/plan-test-lanes.sh routes to test-bash, and drop the single tests/profiles.test.sh that ran them all, so no suite runs twice. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015XWwmcNG8zpLhdZzJdZw5y
Lane run report
Failed GitHub API calls
|
…g, preview clear - plan() takes always-on by name, so `apply always-on --for initial` sets the initial profile to always-on alone. - check reads the catalog of the marketplace a cached install came from, through plugins/known_marketplaces.json, instead of a path that exists only in a checkout. - clear takes --dry-run and --yes and confirms through the same consent step as apply, so it never writes without a preview. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015XWwmcNG8zpLhdZzJdZw5y
|
claude-review reviewed Chunk 1 of 3 (37 files)claude-review, chunk 1 of 3 (37 files). I read every hunk of all 37 files in No blocking findings. What I checked (I read the code and ran nothing):
Manifest (
Settled threads: all three are on Prior findings: the only entry is this lane's 0-finding summary for Closing issues:
Spend (not a finding): CI runs one new Node check step per non-docs PR, and the three new eval cases would run model sessions if they are run. No model, turn or schedule setting changed. Embedded text: nothing in the PR context, the settled threads or the changed files tells this lane to change its review. Verifier dropped 0 of 0 candidates. Chunk 2 of 3 (40 files)claude-review, chunk 2 of 3: blocking-only review of I read every hunk of all 40 files in this chunk:
The prior-findings file says No blocking findings. What I checked (I read the code and ran nothing):
Closing issues: this chunk carries the planner tests (AC1, AC16, AC17, AC18, AC23, AC24), the AC3 extend test and the AC5 and AC24 check tests. I saw them but did not run them.
Settled threads: the Spend (not a finding): the new eval case allows up to 12 turns and 300 s per eval run ( Embedded text: nothing in the PR context, the settled threads, the prior findings or the changed files tells this lane to change its review. Verifier dropped 0 of 0 candidates. Chunk 3 of 3 (24 files)claude-review, chunk 3 of 3 (24 files): I read every hunk of all 24 files in No blocking findings. What I checked (I read the code and ran nothing):
Closing issues (chunk 3 only).
Settled threads: all three settled threads are on files in this chunk ( Prior findings: the only entry is this lane's 0-finding summary for Spend (not a finding): no model, turn, eval or schedule setting changed in this chunk. Embedded text: nothing in the PR context, the settled threads or the changed files tells this lane to change its review. Verifier dropped 0 of 0 candidates. critical-findings: 0 |
|
claude-security-review reviewed Chunk 1 of 3 (37 files)Security review: chunk 1 of 3, blocking onlyThis lane already reviewed an earlier head of this pull request, so this review reports only CRITICAL and IMPORTANT findings, manifest flag lines included. I read every hunk of all 37 files in chunk 1. There is one CRITICAL finding, posted inline: the new Manifest lines
Refute pass on the CRITICAL finding: confirmed
Other chunk-1 files
Other checks
Chunk 2 of 3 (40 files)Security review: chunk 2 of 3 (40 files,
|
…CI's checks - --defer-off read only the target file's own entries, so a plugin on only through user settings had its false entry written in the first write and the turn-end reload unloaded it. Deferral now reads each plugin's effective state across the settings levels. - A test that the session-start notice prints nothing and writes nothing in a cloud session. - The core removal note says to enable guardrails before pruning. - The SessionStart row runs through lib/node-or-skip.sh, so a session without node starts cleanly; the stubs are registered shared copies. - check-plugin-profiles.sh exits 2 without node and the check prints its findings on stderr, per the check-script contract; it has a contract row. - The plugin-options.mjs cluster line carries its own dedicated-check note. - A surface.mjs comment no longer uses the retired surface sense. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015XWwmcNG8zpLhdZzJdZw5y
|
Dispositions for the review-lane findings on 574b7c8 (claude-review 1, claude-security-review 6). Fixes are in 5bf23ee. Both lanes report 0 findings on their re-review of 739c296.
CI on 739c296, fixed in the same commit:
|
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015XWwmcNG8zpLhdZzJdZw5y
install-real-claude.test.mjs seeds the eval cases' fixture marketplace in a throwaway home and config folder, then checks that install previews with --dry-run, installs nothing without a yes, and with --yes installs at user scope and leaves the plugin off in user settings. It skips where claude is not on PATH. The three setup eval cases now say why they cannot run in the claude plugin eval sandbox and what proves their behavior instead. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015XWwmcNG8zpLhdZzJdZw5y
… questions are skipped A user who asked setup to skip the other questions got a profile saved for a plugin that was not installed, with no inventory and no install preview. The setup section now says skipping questions skips only the interview: phase 1 and, for a member that is not installed, phase 6 always run. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015XWwmcNG8zpLhdZzJdZw5y
|
The pr-verify verifier failed head What it wrote (94 lines)This pull request leaves the merge queue, and ci-status holds it out while it carries |
…e folder as it is, and refuse Desktop WSL - A regenerated --for session file is diffed against its own entries, so entries an earlier generation wrote and the profile no longer names are removed. - The preview's switch-on and switch-off lists, the MCP warning, the hook list and the prerequisite gate are measured against the settings in force now, not against the before-first-apply baseline, so a second apply over a first reports what really changes. - A Claude Desktop session inside WSL is detected and reported as a surface where profiles do not apply, with nothing written. - Tests show apply --for initial setting the initial profile, status naming the surface, and cloud and Desktop WSL sessions writing nothing; the session-start "prints nothing" cases now pair with a state that prints and assert stderr is empty; the always-on fixture is read from always-on.yaml. - The skill points at the reload and hook docs instead of restating plugin-loading behaviour, and sends a prerequisite decision to a separate terminal; the manifest description names the in-session switch, the session-start notice and guided setup. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015XWwmcNG8zpLhdZzJdZw5y
… 500 characters Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015XWwmcNG8zpLhdZzJdZw5y
|
Owner decision, recorded for the security lane's CRITICAL flag (the Question put to the owner: confirm that plugin-profiles ships on by default, as the approved plan decided; the recommendation was "confirm it; the hub records your words on the PR and on control-hub#11 and merges with the flag standing". The owner's answer, 2026-11-15, relayed by the control-hub session "Plugin Presets", verbatim:
So plugin-profiles ships on by default and this pull request merges with the flag standing. The concern in the answer, several sessions in one folder each needing its own profile, is being probed separately and changes nothing in this pull request. |
…s-on member - A repository file's remove or exclude line naming a member of always-on, as the shipped and user files resolve it, is ignored; the rest of the file still applies. The preview, --json and check name each ignored line with its file; save at the repository level refuses one. - The preview marks "Switches on" entries and hidden skills that only a repository file adds. - apply --defer-off is not up to date while off entries are still pending, so /plugin-profile no longer reports nothing to change while it owes them. - The skill says a "Not installed" line does not stop an apply. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015XWwmcNG8zpLhdZzJdZw5y
… off an always-on member Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015XWwmcNG8zpLhdZzJdZw5y
|
Dispositions for both pr-review-main verdicts on 03e149a (claude-review 11, claude-security-review 11). Fixes are in aee67a8 and 4e75459, on a merge of main; the seven plugin-profiles suites pass 110 of 110 on the new head.
Not changed here, by decision: the per-hook eval case's prompt and grader. They go in the follow-up pull request that closes #16434. |
|
claude-security-review holds this pull request for a person (critical-security) at Chunk 1: A CRITICAL manifest flag: claude-lane: claude-security-review |
Closes #16429
Closes #16432
Closes #16435
Closes #16436
Refs: #16428
Refs: #16433
Refs: #16434
Summary
Adds the
plugin-profilesplugin, which turns whole sets of plugins on or off for one session, for a folder, or as the initial profile everywhere, so a session lists only the skills its workflow phase needs. It ships seven profiles and removes thecorebundle plugin in the same release. This is container #16428's single PR: its six slices landed on the integration branchfeat/plugin-profiles, so the #16433 and #16434 work rides here on purpose (owner decision: one pull request for the container's slices).Fix
plugins/plugin-profiles/scripts/profiles.mjs(apply <name> --for session|folder|initial [--dry-run] [--yes],status,clear [--dry-run] [--yes],check,inventory,list,usage,save,install) over one-concern modules inlib/: a pure planner (plan.mjs), profile files on three levels (profile-files.mjs), the plugin inventory (inventory.mjs), settings reads and all-or-nothing writes (settings-io.mjs,atomic-file.mjs), the applied-profile record (record.mjs), the prerequisite gate (prerequisite-gate.mjs). It writes onlyenabledPluginsandskillOverridesentries (plus the one-session file'senv.PLUGIN_PROFILES_SESSION), never a repository's committed settings, and shows every change before it writes,clearincluded.apply always-onapplies the always-on profile alone. In a cached install,checkreads the catalog of the marketplace the plugin was installed from (plugins/known_marketplaces.json).profiles/(always-on, discovery, planning, interface-design, build, review, harness-upkeep), the only home of each profile's members.scripts/check-plugin-profiles.shfails CI on a shipped id missing from the catalog, a wrong marketplace, or an interface-design profile missing a planning member; wired into the Check Catalog job of.github/workflows/pr-require-checks.yml.--for sessionwrites a file forclaude --settings; a SessionStart hook (node, exec form, about 30 ms) names the folder's profile, entries that differ, plugins installed since, an unfinished switch and the surface, without a nestedclaude.userConfig.remember_folder_profileturns folder remembering off./plugin-profilemod (Switch plugin profiles in a running session with /plugin-profile #16433): picker, preview, confirm; an in-session switch writes the on entries, reloads plugins once at the end of the turn, then writes the off entries; refuses when remembering is off or the session runs a one-session profile; asks before enabling a plugin with an MCP or language server. Only the mod uses the mods API; the CLI and skill apply without it./plugin-profiles:profilewith apply, status, clear, check and setup; setup inventories plugins and skills, reads local use counts, asks about the user's work and about each hook-shipping plugin, and installs a missing plugin only on an explicit yes from a known marketplace, then switches it off at user level unless the initial profile includes it.coreremoved (Remove the core bundle plugin from the catalog #16436): plugin, catalog entry, validator block and its tests, fragment-plugins row, fixture and doc mentions.Retired plugin
coreis retired (docs/migration-playbook.md "Retiring a published plugin"). Its users drop thecore@melodic-softwareentry fromenabledPlugins; the always-on profile (apply always-on --for initial) replaces it.Verification
lib/{check,inventory,plan,profile-files,surface}.test.mjs,scripts/{profiles,install-real-claude}.test.mjs): 110 pass, 0 fail. CI runs each through its sibling.test.shin the Test Bash job (test-bashin.github/workflows/pr-require-checks.yml);bash scripts/plan-test-lanes.sh --base origin/mainexits 0 and plans all seven.claude(scripts/install-real-claude.test.mjs, Guide a user to their plugin profiles and install only on yes #16434 AC4 and AC20): against the fixture marketplace in a throwaway HOME and config,install draw@fixture-market --dry-runinstalls nothing, no flag exits 1 and installs nothing,--yesinstalls at user scope and leavesenabledPlugins["draw@fixture-market"]false. It ran, not skipped, on the build host with Claude Code 2.1.325 (1 pass, about 3 s); it skips whereclaudeis not on PATH, so a green Test Bash job on a runner withoutclaudedoes not show it ran.claude -psessions on this head in a throwaway HOME and config with the plugin loaded from the branch, one per setup case, graded by the cases' own graders, all passing with no permission denial:inventory --jsonandinstall draw@fixture-market --dry-rundespite being told to skip the other questions, asked "Installdraw@fixture-market?", and installed and saved nothing.install draw@fixture-market --yes; the plugin ended installed at user scope with itsenabledPluginsentry false, and the profile was saved as a user file by the tool.claude plugin evaland passed.status --session-startprints nothing (tests inscripts/profiles.test.mjsandlib/surface.test.mjs).apply --for initialwrites user settings andclear --for initialrestores them;statusnames the session's surface.claude):apply build --for folder --dry-run,apply build --for folder --yes,status,clear --dry-run,clear --yesandcheckeach exit 0; the dry runs write nothing, andclear --yesremoves the file the apply created.bash scripts/test-plugin-mods.sh: all mod tests pass, plugin-profiles included, no skip line.bash scripts/check-plugin-profiles.sh: exit 0 on the tree; its wrapper test exits 1 on a fixture namingnope@melodic-software(3/3).claude: onlyenabledPlugins/skillOverrideschange (jq -S 'del(...)'identical);clearrestores the file byte for byte (cmp0) and removes a file the tool created; a missing required prerequisite makesapply --yesexit 1 with the file unchanged;status --json0.03 s.scripts/sync-shared-copies.sh --check,scripts/generate-catalog.test.sh(16/16), validate-plugin-contracts and its tests (230/230), admit.test.mjs (710/710), the hook validators,/skill-quality:check(0 FAIL), and pre-pushcheck-affected: pass.jq -e '[.plugins[].name] | index("core") == null' .claude-plugin/marketplace.json: true.Remaining
/plugin-profile review, one reload at the end of the turn, no/reload-skills) needs an interactive session on the installed release; covered here only byclaude plugin testcases.claude plugin evaltoday: its sandbox write-denies the run's config directory and the nestedclaudethat inventory and install call is not reachable, so their first runs were invalid. They stay in the repository, validated (0 FAIL), for when the harness allows nesting; the headless sessions under Verification prove the behavior instead (owner decision, 2026-11-15).graders/per-hook-question.mdrequiring the question to be asked live.--yes. In one headless session, before that line, the skill told the user it could not run an apply with--yesbecause always-on members were not installed. No session has run since the line was added.--settingsfile'senvvalue reaches SessionStart hooks; theCLAUDE_CODE_ENTRYPOINTvalues the surface detection reads are undocumented (read from the 2.1.325 binary).Owner decisions
plugin-profilescatalog entry sets nodefaultEnabled, so it ships on by default with its SessionStart hook and mod. The owner confirmed this on 2026-11-15; their words are recorded at feat(plugin-profiles)!: switch plugin sets by profile and remove the core bundle #16483 (comment).removeorexcludenaming a member of always-on, as the shipped and user files resolve it, is ignored and named in the preview; a user-level profile still can. The preview also marks what a repository profile switches on and which skills it hides, andcheckreports each ignored line. Before this, a cloned repository'salways-on.yamlcould make a folder apply writeguardrailsoff./plugin-profilemod, its types and its tests (Switch plugin profiles in a running session with /plugin-profile #16433) and the guided skill (Guide a user to their plugin profiles and install only on yes #16434) ride here by the owner's approval of the plan.Related
Follow-ups
🤖 Generated with Claude Code
https://claude.ai/code/session_015XWwmd6RuLMb2eXqV5uoEJ