Repository navigation
docs: re-apply prompt-audit history, provenance and stale-fact fixes - #16410
Conversation
The restore pull request (#16379) put back skill and agent text a prompt audit had changed without eval evidence. It also put back text the repository's own rules forbid: history and provenance notes, migration-relative wording and as-of dates on plain pointers. Those are not cuts under the skill criteria's "History and provenance" section. This re-applies those edits, lower-cases all-caps emphasis on ordinary words where no test pins the wording, and corrects stale paths, counts and cross-references confirmed against the repository. Edits that change behavior, drop a number still in use, or touch eval judge text stay restored. Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Lane run report
Failed GitHub API calls
|
|
claude-security-review reviewed Security review (incremental, cc08476 → 2cc93a9): no security issues foundcritical-findings: 0 I read the whole incremental diff. It touches one file: What changed: one sentence in the "Basis" note at command-evidence.md#L23. It used to say that item 2 evidence needs a project's own hook. It now says that item 2 comes from a project's own hook or a transcript tool result. Instruction-surface lens: this does not widen the evidence rule. Item 2 at L14-L16 already lists "a transcript tool result matched by its tool-use id", and that line is unchanged. The edit makes the Basis note agree with it. Item 3 is unchanged: a worker's prose, a Other surfaces: the change touches no manifest, Spend: none. |
|
Hold ( The hold comes off when #16346, #16321 and #16348 have merged, or sooner if this pull request stops changing that one file. Its other 144 files raise no concern. |
Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
|
claude-review reviewed Incremental review of This review covered only the blocking class, because the prior-findings file says The push changes one line, I had no shell and ran nothing. There is no closing issue, so there were no acceptance criteria to check. The incremental diff, prior-findings file and PR context held no embedded instructions aimed at this lane. Verifier dropped 0 of 0 candidates. |
|
Commit cc08476 takes That meets the hold's second condition ("sooner if this pull request stops changing that one file"). The label is the hub's to remove; this session leaves it in place and does not merge while it is set. |
…weep-all figures Co-Authored-By: Claude Fable 5.2 <noreply@anthropic.com>
|
Hold lifted by the GitHub Support hub: head |
No related issue: follow-up to the prompt audit; re-applies rule-backed edits that #16379 restored
Summary
#16379 restored skill and agent text a prompt audit had changed without eval evidence. It also restored text the repository's own rules forbid: history and provenance notes, migration-relative wording ("now", "no longer", "as before") and as-of dates on plain pointers. Removing those is not a cut under
plugins/playbooks/skills/skill-authoring/reference/skill-criteria.md("History and provenance") or.claude/rules/skill-bodies-state-current-rules.md. This puts those edits back and leaves every real cut restored.Fix
patchchangelog fragment for each of the 34 plugins whose shipped files change.Verification
scripts/check-affected.sh --tests: 16 checks passed, including markdown lint, changelog fragments and the stale-base check after merging main.scripts/sync-shared-copies.sh --check: all 904 registered copies match.plugins/planning/tests/interview-defenses.test.sh: 185 passed, 0 failed.plugins/prototype/skills/explore-directions/reference/bundled-design.mdis left unchanged because running evals for feat(prototype): say where a notes session's files go and add the dossier case #16346, fix(prototype): allow one shared states line in the explore-directions handover #16321 and feat(prototype): add the controls tab, manifest and control snapshots in notes #16348 read it..githubtest suites, which ran past the local time budget and run in CI.Related
Follows #16379, which restored text changed by #16328, #16330, #16331, #16332, #16333, #16334, #16336, #16337, #16339 and #16340.
Intentional-removal: history and provenance notes, migration-relative wording and as-of dates on plain pointers are removed on purpose; the skill criteria forbid them in skill text.
🤖 Generated with Claude Code