Skip to content

chore: apply prompt-audit fixes from harness-config to kindle-dedrm - #16333

Merged
kyle-sexton merged 2 commits into
mainfrom
chore/prompt-audit-harness-config-to-kindle-dedrm
Nov 15, 2026
Merged

kyle-sexton merged 2 commits into
mainfrom
chore/prompt-audit-harness-config-to-kindle-dedrm

Conversation

@kyle-sexton

Copy link
Copy Markdown
Member

No related issue: prompt-audit findings from an owner-requested full-read audit

Summary

Group 5 of 10 from a full-read prompt audit (Anthropic's prompt-audit guide) of the marketplace's instruction text, covering the harness-config, harness-memory, harness-ops, implementation, improvement, instruction-placement, javascript-format and kindle-dedrm plugins. Each edit was checked by a second agent, and fix-agent edits were reviewed again.

The change is instruction text: skill bodies, references, READMEs, and comments or printed notes inside scripts. Two script edits change behavior: plugins/instruction-placement/scripts/verify-load.sh now passes --disallowedTools Agent to its probe session, and plugins/harness-ops/skills/audit-native-overlap/scripts/overlap.py prints the real fingerprint length (FINGERPRINT_LEN, 32) in a validation message that said 16.

Fix

  • Capital-letter emphasis markers lowered to plain words (ADR 0098), in prose and in script notes.
  • Stale paths and facts corrected (for example the auto-memory path under CLAUDE_CONFIG_DIR, the handoff-notes location in the implementation README, /harness-ops:inventory added to the harness-ops README).
  • Restated upstream facts replaced by pointers to the live Claude Code docs (settings scopes in cloud sessions, server-managed settings cache, where plugin environment variables resolve), and copied version gates given an as-of date and recheck trigger.
  • Contradictions between files settled toward the newer rule (the improvement README now says a PR opens ready or draft by the repository's open-state rule).
  • One changelog fragment per changed plugin (8, all patch).

Left out of the audit patch: the plugins/kindle-dedrm/skills/manage/scripts/sync-prep.sh hunk, because sync-prep.test.sh asserts the upgrade-refusal wording it changed (if Kindle prompts to upgrade, REFUSE). The test stays; that file is unchanged.

Verification

  • Script suites for every touched script pass: inventory.test.sh (133), permission-merge.test.sh (92), automode-entry-diff.test.sh (76), automode-block-lint.test.sh (76), audit.test.sh (37), changelog-status.test.sh (96), lane-launcher.test.sh (512), restart-consumer.test.sh (213), verify-load.test.sh (18), mechanics-sources.test.sh (12), check-drift.test.sh, sync-prep.test.sh after the revert, overlap.test.sh (205) and the install_state unittest suite (91).
  • scripts/sync-shared-copies.sh --check: all 904 registered copies match. scripts/check-changelog-fragments.sh --check and --check-required origin/main: 8 fragments valid, one per changed plugin. markdownlint-cli2 over the touched plugins: 0 issues. The pre-push check-affected hook passed.
  • Left out: the full .github suite and model-graded evals, which CI and the review lanes run.

Related

N/A

🤖 Generated with Claude Code

Apply the verified prompt-audit edits to the harness-config,
harness-memory, harness-ops, implementation, improvement,
instruction-placement, javascript-format and kindle-dedrm plugins:
capital-letter emphasis lowered (ADR 0098), stale paths and facts
corrected, restated upstream facts replaced by pointers, and copied
version gates given an as-of date and recheck trigger.

The kindle-dedrm sync-prep.sh hunk is left out: its test asserts the
upgrade-refusal wording the audit edit changed.

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
@kyle-sexton
kyle-sexton marked this pull request as ready for review November 15, 2026 13:57
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 15, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-15T13:59:51.822546Z f319416 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

Copy link
Copy Markdown
Contributor

Lane run report

Field Value
Activity pr-refine/fix-docs
Model rung 0
Leg handoff
Run job success
Activity step success
Commits pushed none (read lane)
Run 43721768441

Failed GitHub API calls

Method Path Status
GET /repos/{repo}/git/ref/tags/* 404

@github-actions

github-actions Bot commented Nov 15, 2026 •

Copy link
Copy Markdown
Contributor

claude-security-review reviewed 3772157b6a62d32fcdc5d9dc6f8477fb4849192e: read 1 of 1 changed file(s); 0 finding(s), 0 as inline comments.

Security review (incremental, f319416 → 3772157)

I found no security issues in this push.

What I read. The scope is one file, plugins/implementation/skills/implement-dispatch/SKILL.md, and I read every hunk of it in .claude-lane/incremental.diff. The push changes one line. In the rule "Major divergence (fundamental assumption wrong) still stops even autonomously", the word "stops" goes back to the pinned uppercase phrase "STOPS". The rule means the same thing as before, and the text after it is unchanged: "Park the run with a handoff rather than improvising a new design".

Instruction-surface check. Nothing is deleted, narrowed or softened. The push only brings back emphasis on a rule that was already there, so no protected class loses a check. I did not open the protected-class register because there was no removal to check against it.

Other checks.

  • Trusted paths: the file matches no glob on the TRUSTED PATHS list.
  • Trust controls and holds: no trust control, merge hold or plugin manifest is touched.
  • Manifests: no manifest lines apply.
  • Spend: the push adds no spend.

Prior findings and mode. The lane's earlier post at f319416 had 0 findings, so nothing is carried forward. This review was blocking only (blocking only: yes), which means SUGGESTION findings would have been dropped; there were none.

critical-findings: 0

@github-actions

github-actions Bot commented Nov 15, 2026 •

Copy link
Copy Markdown
Contributor

claude-review reviewed 3772157b6a62d32fcdc5d9dc6f8477fb4849192e: read 1 of 1 changed file(s); 0 finding(s), 0 as inline comments.

Code-review lane, incremental review (f319416 → 3772157): no findings. This review was blocking only, because this lane already reviewed an earlier head.

The change since the last review is one line in plugins/implementation/skills/implement-dispatch/SKILL.md. The Gates bullet "Major divergence (fundamental assumption wrong) still stops even autonomously" goes back to "still STOPS even autonomously". I read the whole hunk.

Checked with my own tools (nothing run):

  • plugins/implementation/skills/implement-dispatch/reattach-slice.test.sh:39 asserts the exact phrase 'Major divergence (fundamental assumption wrong) still STOPS'. The earlier lowercase edit broke that pin. This commit restores the text the test expects: SKILL.md#L22.
  • This restores the capitals the PR otherwise lowercases. It is a pinned gate phrase, so the exception is justified.
  • No other file still holds the lowercase form of this gate phrase. The lowercase "Major divergence still stops the run" at SKILL.md:227 is a different sentence and nothing pins it.

Closing issue: none. The PR context names no related issue, so there are no acceptance criteria to check.

Manifests: this change touches no plugin.json or marketplace.json.

Prior findings: the only prior post is the summary comment, which has no line anchor and was a 0-finding review, so there is nothing to restate.

Verifier dropped 0 of 0 candidates.

…t-dispatch

reattach-slice.test.sh pins "Major divergence (fundamental assumption
wrong) still STOPS" inside the re-attach slice; the audit edit lowercased
it and failed Test Bash (2). Revert that line to main's text.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@kyle-sexton
kyle-sexton added this pull request to the merge queue Nov 15, 2026
Merged via the queue into main with commit 419ceee Nov 15, 2026
49 checks passed
@kyle-sexton
kyle-sexton deleted the chore/prompt-audit-harness-config-to-kindle-dedrm branch November 15, 2026 15:37
@kyle-sexton kyle-sexton added the do-not-merge Hard merge gate: do not merge while applied. label Nov 15, 2026
@github-actions github-actions Bot added the merge-path: owner-agent Post-merge accounting record (README.md, Merge paths) label Nov 15, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Post-merge mutation testing

Killed 3, survived 4, timeout 0, no coverage 0, invalid 0, not run 0.
Covered-code score 43%; mutation score 43%.

File Killed Survived Timeout No coverage Invalid Not run
plugins/harness-config/skills/audit-automation-gaps/scripts/inventory.sh 1 0 0 0 0 0
plugins/harness-config/skills/audit-permission-state/scripts/automode-block-lint.sh 1 0 0 0 0 0
plugins/harness-config/skills/audit-permission-state/scripts/automode-entry-diff.sh 1 0 0 0 0 0
plugins/harness-config/skills/audit-permission-state/scripts/permission-merge.sh 0 1 0 0 0 0
plugins/harness-ops/skills/audit-native-overlap/scripts/overlap.py 0 1 0 0 0 0
plugins/instruction-placement/scripts/verify-load.sh 0 1 0 0 0 0
plugins/kindle-dedrm/skills/manage/scripts/cleanup.sh 0 1 0 0 0 0

Surviving mutants

Location Operator Disposition Cause
plugins/instruction-placement/scripts/verify-load.sh:175 other productive input-gap
plugins/harness-ops/skills/audit-native-overlap/scripts/overlap.py:991 AOR productive no-assertion
plugins/harness-config/skills/audit-permission-state/scripts/permission-merge.sh:277 SBR productive no-assertion
plugins/kindle-dedrm/skills/manage/scripts/cleanup.sh:81 SBR productive input-gap

The run's summary has the full report.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge Hard merge gate: do not merge while applied. merge-path: owner-agent Post-merge accounting record (README.md, Merge paths)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant