Repository navigation
chore: apply prompt-audit fixes to songwriting through tdd plugins - #16340
Conversation
Apply the verified prompt-audit findings for the songwriting, source-control, spelling, sql-server and tdd plugins: lower-case capital-letter emphasis (ADR 0098), drop history narration, correct stale paths and claims, and settle contradictions between files toward the owning file. The sql-server tool descriptions now state each tool's return shape, default limits and failure modes. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Collapse a double blank line, keep an issue list from starting a line with a hash, use the American spelling the typos gate wants, and drop worktree-root-convention.md from the as-of recheck baseline now that its as-of date carries a recheck trigger. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Reflow the severity-screen sentence onto two lines so the skill stays below the 500-line hard cap check-skill enforces. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: da7b8e61ae
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Lane run report
Failed GitHub API calls
|
Lane-Activity: pr-refine/fix-docs
Lane run report
Failed GitHub API calls
|
Restore three skill and agent passages the audit cut or reworded without the before-and-after eval evidence docs/review/skills-and-agents.md requires: the object-writer return rule's observed-stumble evidence (#6031), babysit-prs' "Quality over speed" note, and prep's default dispatch of parallel verification agents. Restore the capitalized words in three worktree-root-doctor.sh messages that worktree-root-doctor.test.sh asserts (cases 38, 43 and 47). Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
|
claude-security-review reviewed Security review (incremental, blocking only): PR #16340 at
|
|
claude-review reviewed claude-review: incremental review of This push changes the "Body language" section note in I checked the pointer by reading the files:
So the new note no longer contradicts the roadmaps file. Notes:
Verifier dropped 0 of 0 candidates. |
|
The pr-verify verifier failed head What it wrote (53 lines)This pull request leaves the merge queue, and ci-status holds it out while it carries |
The audit's rewrite said no source exists for quoting Pat on body language, but lyric-melodic-roadmaps.md quotes his patpattison.com column "The Art of Phrasing". Point at that quote and keep the rule against attributing the framing to a book. Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
No related issue: prompt-audit findings from an owner-requested full-read audit
Summary
A full-read prompt audit (Anthropic's prompt-audit guide) found instruction text written for older models, stale against the repository, or contradicted by another file. This PR applies the verified findings for the
songwriting,source-control,spelling,sql-serverandtddplugins (group 9 of 10, 124 files). Every edit was confirmed by a second agent before it was written.The change is instruction text only, except for five code files whose edits are confined to text a model or user reads:
plugins/source-control/scripts/worktree-create.sh: usage text and one comment, emphasis lower-cased.plugins/source-control/scripts/worktree-root-doctor.sh:note/warnmessage strings and comments, emphasis lower-cased except the three strings its test asserts.plugins/source-control/skills/babysit-prs/scripts/babysit_merge.pyandbabysit_resolve_thread.py: module docstrings only, emphasis lower-cased.plugins/sql-server/src/tools.mjs: thedescriptionstrings ofquery,list_objects,describe_objectandwritenow state the return shape, the default row cap and request timeout, and the failure modes. Each claim matchessrc/executor.mjs(DEFAULT_LIMITS, the returned objects, the write verdict) andsrc/statement.mjs(the refusals).Fix
babysit_resolve_thread.pyapplies that screen only under--autonomousand--independent-resolver, so the docs now say the agent carries the escalation in the other resolve modes. The rule itself (escalate a security/P1 thread in every tier and mode) is unchanged.tdd: the Child Test trigger and the integration-test share of the pyramid now match the Beck and Khorikov references the skill summarizes.#(MD018),labelledtolabeled(typos), the severity sentence inbabysit-prs/SKILL.mdreflowed to stay under the 500-line cap, andworktree-root-convention.mdremoved fromscripts/as-of-recheck-baseline.txtbecause its as-of date now carries a recheck trigger, as the check asked.patchchangelog fragment for each of the five plugins.Reverted audit hunks:
plugins/songwriting/agents/object-writer.md(the fix(songwriting): object-writer returns several pivot sentences where it is asked for one #6031 observed-stumble evidence),plugins/source-control/skills/babysit-prs/reference/loop.md("Quality over speed") andplugins/source-control/skills/pull-request/reference/prep.md(default parallel verification agents): cuts or behavior rewrites in skill and agent text thatdocs/review/skills-and-agents.mdallows only with before-and-after eval evidence, which this PR does not carry (Codex review finding).plugins/source-control/scripts/worktree-root-doctor.shkeep their capitalizedWITH,AFTER/ABOVEandINSIDE:worktree-root-doctor.test.shcases 38, 43 and 47 assert them.The
pr-refine/fix-docslane added 6b364c1, which rewrites figurative phrasing in 26 songwriting reference files into literal wording.Verification
git apply --3wayof the group patch: every hunk applied cleanly on currentmain; no file dropped.plugins/source-control/scripts/worktree-root-doctor.test.sh: 0 failures after the message reverts.scripts/sync-shared-copies.sh --check: all 904 registered copies match.scripts/check-changelog-fragments.sh --checkand--check-required origin/main: pass for all five plugins.scripts/check-affected.sh --tests: 17 checks passed after the lint fixes;scripts/check-changed-skills.sh: 19 skills, 0 failed. Suites past the local 120 s budget are left to CI.node --test plugins/sql-server/test/server.test.mjs plugins/sql-server/test/defaults.test.mjs: 67 passed, 0 failed.Related
🤖 Generated with Claude Code