Repository navigation
Conversation
pytest 9.2 removed Node._nodeid, which pytest-benchmark 5.3.0 and older still read (ionelmc/pytest-benchmark#321), so the benchmark test errors at setup. Skip it in that case; it runs again once pytest-benchmark releases a fix. Signed-off-by: Raphael Bizos <r.bizos@criteo.com> Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Oct 28, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pytest 9.2 (released 2026-10-27) removed
Node._nodeid, whichpytest-benchmark 5.3.0 and older still read
(ionelmc/pytest-benchmark#321, fix in ionelmc/pytest-benchmark#323). Since
then
test_benchmark_text_string_to_metric_familieserrors at setup onevery CI run.
Skip that test when pytest no longer has
Node._nodeidand pytest-benchmarkis 5.3.0 or older, instead of pinning pytest for the whole suite. It runs
again on its own once pytest-benchmark releases a fix.
@csmarchbanks