Skip to content

parser: cherry-pick #868, #856, #836, #855 to 4.0-itai - #882

Merged
AilinKid merged 5 commits into
pingcap:4.0-itaifrom
AilinKid:local-itai2
Jun 2, 2020
Merged

AilinKid merged 5 commits into
pingcap:4.0-itaifrom
AilinKid:local-itai2

Conversation

@AilinKid

@AilinKid AilinKid commented Jun 1, 2020 •

Copy link
Copy Markdown
Contributor

What problem does this PR solve?

cherry-pick:
support partition selection grammer for the delete statement (#868)
support the syntax insert into tbl_name partition (#856)
Fix set charset statement (#836)
support show table partition regions (#855)
to 4.0-itai

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test

@AilinKid AilinKid changed the title parser: support partition selection grammer for the delete statement … parser: support partition selection grammer for the delete statement (#868) Jun 1, 2020
@AilinKid
AilinKid requested review from tangenta and zimulala June 1, 2020 10:47
@codecov

codecov Bot commented Jun 1, 2020 •

Copy link
Copy Markdown

Codecov Report

❗ No coverage uploaded for pull request base (4.0-itai@4c8a0b6). Click here to learn what that means.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             4.0-itai     #882   +/-   ##
===========================================
  Coverage            ?   78.20%           
===========================================
  Files               ?       40           
  Lines               ?    14671           
  Branches            ?        0           
===========================================
  Hits                ?    11474           
  Misses              ?     2514           
  Partials            ?      683           

@zimulala zimulala left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

* test

* support the syntax insert into tbl_name partition

* address comment
@AilinKid AilinKid changed the title parser: support partition selection grammer for the delete statement (#868) parser: cherry-pick #868, #856 to 4.0 itai Jun 1, 2020
AilinKid and others added 2 commits June 1, 2020 19:12
.
Signed-off-by: AilinKid <314806019@qq.com>
@AilinKid AilinKid changed the title parser: cherry-pick #868, #856 to 4.0 itai parser: cherry-pick #868, #856, #836 to 4.0 itai Jun 1, 2020

@tangenta tangenta left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kennytm kennytm added the status/LGT2 LGT2 label Jun 1, 2020
Signed-off-by: crazycs520 <crazycs520@gmail.com>
@AilinKid AilinKid changed the title parser: cherry-pick #868, #856, #836 to 4.0 itai parser: cherry-pick #868, #856, #836, #855 to 4.0 itai Jun 2, 2020
@AilinKid AilinKid changed the title parser: cherry-pick #868, #856, #836, #855 to 4.0 itai parser: cherry-pick #868, #856, #836, #855 to 4.0-itai Jun 2, 2020
@AilinKid
AilinKid merged commit 0f6ff1a into pingcap:4.0-itai Jun 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants