Skip to content

parser: support partition selection grammer for the delete statement - #868

Merged
tiancaiamao merged 1 commit into
pingcap:masterfrom
tiancaiamao:delete-partition-selection
May 22, 2020
Merged

tiancaiamao merged 1 commit into
pingcap:masterfrom
tiancaiamao:delete-partition-selection

Conversation

@tiancaiamao

Copy link
Copy Markdown
Contributor

What problem does this PR solve?

Support delete from t partition (p0,p1) ...

What is changed and how it works?

update parser.y

Check List

Tests

  • Unit test

Related changes

  • Need to cherry-pick to the release branch

@tiancaiamao
tiancaiamao requested a review from a team May 22, 2020 08:12
@ghost
ghost requested review from kennytm and removed request for a team May 22, 2020 08:12
@codecov

codecov Bot commented May 22, 2020

Copy link
Copy Markdown

Codecov Report

Merging #868 into master will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #868   +/-   ##
=======================================
  Coverage   78.30%   78.30%           
=======================================
  Files          40       40           
  Lines       14681    14682    +1     
=======================================
+ Hits        11496    11497    +1     
  Misses       2502     2502           
  Partials      683      683           

@tiancaiamao

Copy link
Copy Markdown
Contributor Author

PTAL @XuHuaiyu @imtbkcat

@XuHuaiyu XuHuaiyu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tiancaiamao

Copy link
Copy Markdown
Contributor Author

/rebuild

@kennytm kennytm added the status/LGT1 LGT1 label May 22, 2020

@kennytm kennytm left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kennytm kennytm added status/LGT2 LGT2 and removed status/LGT1 LGT1 labels May 22, 2020
@tiancaiamao
tiancaiamao merged commit 3b720a0 into pingcap:master May 22, 2020
@tiancaiamao
tiancaiamao deleted the delete-partition-selection branch May 22, 2020 09:49
@sre-bot

sre-bot commented May 22, 2020

Copy link
Copy Markdown

cherry pick to release-4.0 failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants