Generated v1.0 models and request builders using Typewriter - #845
Conversation
Vincent Biret (baywet)
left a comment
There was a problem hiding this comment.
4-2-0_to_java.zip
Mustafa Zengin (@zengin) Andrew Omondi (@andrueastman) Ramses Sanchez-Hernandez (@ramsessanchez) this update technically introduced a breaking change: the targetApps actions now bind to targetedManagedAppProtection which inherits managedAppProtection instead of managedAppProtection.
Although this would only break people using the request builders directly and not through the fluent API, it's a similar case to the Teams API replacing identitySet by chat message identity set a couple of weeks ago which "forced" us to major rev. See #818
I wanted to get your opinion on this one?
|
I took the time to chat about that to DeVere Dyett (@ddyett) and his instructions are to major rev same thing for dotnet Andrew Omondi (@andrueastman) |
|
Thanks for the heads up Vincent Biret (@baywet) |
|
Ramses Sanchez-Hernandez (@ramsessanchez) would you mind bumping the major version for this one please? |
|
Vincent Biret (@baywet), Ramses Sanchez-Hernandez (@ramsessanchez) |
c8d4a1f
|
Thanks for the additional information Andrew Omondi (@andrueastman) If we compare the previous full metadata file with the current one we can see that 2 things happened:
Because You can have a look at the pkgdiff, specially at the following files
Now, the chances of anyone hitting these breaking changes are low, but it's still technically a breaking change for Java. And it might be for dotnet, depending on whether or not dotnet generates actions request builders inherited from parent types. Hence the major bump on Java/ |
9472879
Andrew Omondi (andrueastman)
left a comment
There was a problem hiding this comment.
Thanks for taking the time to explain this Vincent Biret (@baywet).
I don't think we will need to bump up the major version for dotnet this time as we do not generate action request builders inherited from parent types at moment.
In the dotnet case the change simply shows up as a new method in the "child" request builder class.
|
Ramses Sanchez-Hernandez (@ramsessanchez) we should be good to merge and release whenever you have time :) |
This pull request was automatically created by the GitHub Action, create pull request.
The commit hash is 1932dd7.
Important Check for unexpected deletions or changes in this PR.