Generated v1.0 models and request builders using Typewriter - #818
Merged
Conversation
github-actions
Bot
requested review from
Michael Mainer (MIchaelMainer),
Vincent Biret (baywet),
DeVere Dyett (ddyett),
Nikitha Chettiar (nikithauc) and
Mustafa Zengin (zengin)
as code owners
July 6, 2021 10:10
Vincent Biret (baywet)
requested changes
Jul 6, 2021
Vincent Biret (baywet)
left a comment
Member
There was a problem hiding this comment.
blocking as it contains a breaking change until a decision is made.
3-9-0_to_java.zip
Michael Mainer (MIchaelMainer)
previously approved these changes
Jul 6, 2021
Michael Mainer (MIchaelMainer)
left a comment
Contributor
There was a problem hiding this comment.
Per Darrel, there are no more known breaking changes coming.
Member
|
Thanks for the additional details Michael Mainer (@MIchaelMainer) . Are we major bumping? Or hoping no-one will run into the case I had to fix in my unit test? |
Vincent Biret (baywet)
approved these changes
Jul 7, 2021
Michael Mainer (MIchaelMainer)
approved these changes
Jul 7, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request was automatically created by the GitHub Action, create pull request.
The commit hash is f097d95.
Important Check for unexpected deletions or changes in this PR.