Repository navigation
fix(pr-unblock): route dependency-fix-refused to a session builder, not the owner - #17559
kyle-sexton wants to merge 1 commit into
Conversation
…ot the owner A non-Dependabot commit on a dependency update comes from one of our own actors, so holding it for the owner as a security stop was friction. It now fails with needs-session; a session builder drops or rebuilds the commit and the new head starts clean. dependency-escalate-security still holds a real HIGH or CRITICAL risk for the owner. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01KeBVgeasNxAPMueGtzfrDM
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
claude-review reviewed Code review: no findingsThis PR moves
Checked:
Verifier dropped 0 of 0 candidates. |
|
claude-security-review reviewed Security review: no security issues foundThis pull request reroutes the What I checked. The
So the change does not let anything merge that the base would have stopped. The I also checked whether rerouting sends untrusted text to an automated lane that holds credentials. It does not: no workflow acts on Owner threat model. Before this change, the stop was a person-approval hold on a non-Dependabot commit, made by one of the owner's actors (anyone who can push the branch has write access). Removing that hold is a named friction-hold removal, so it is not a finding. The kept security control for untrusted provenance is the verdict job's refusal to post a merge marker, and it is unchanged. No pull request text tries to give the lane instructions. No change can bill or spend extra credits. critical-findings: 0 |
|
The pr-verify verifier failed head What it wrote (33 lines)This pull request leaves the merge queue, and ci-status holds it out while it carries |
Refs: #17569
Owner decision: owner-decisions.md line 248 (record PR melodic-software/architecture#115).
verbatim: "with recommendations. Again, the security issue has to be critical, like an actual security issue"
Summary
dependency-fix-refusedheld a Dependabot pull request for the owner as asecuritystop (needs-human) whenever a commit other than Dependabot's was on the branch. Every such commit comes from one of our own actors, so the hold guarded only against them. Under the owner's standing direction that is friction, not a security boundary: only a token or secret leak, an account compromise or billing goes to the owner (§3, §10). The owner confirmed this for this case on 2026-11-19 (row and quote above).#17344 shows the cost: the lane held it at 04:20Z. The
@dependabot recreateat 06:14Z already removed the foreign commit, but the label stayed until a session removed it at ~23:08Z.Fix
.github/scripts/pr-unblock/escalation-routes.json:dependency-fix-refusedroutesfailwithneeds-sessioninstead ofholdwith owner reasonsecurity. A session builder drops or rebuilds the commit (for example@dependabot recreate), and the new head starts clean.dependency-escalate-securitystill holds a HIGH or CRITICAL risk in the update for the owner..github/scripts/pr-unblock/report-escalation.test.sh: moves the reason fromHOLD_REASONS/OWNER_REASONStoSESSION_REASONS. The test's route check then asserts the row appliesneeds-session, notneeds-human. It also deletes the two comment blocks that restated the arrays, which the comment lint flagged on the edited lines..github/scripts/pr-merge/clear-escalations.test.mjs: the reason joins the review-dependencyfailroutes.docs/conventions/pr-pipeline/README.md: names the stop as a session-builder one..changes/pr-pipeline/: patch fragment.The workflow's reason allow-lists (
pr-run-activity-write.yml) only check that the script may give the reason, so they need no change.Verification
bash .github/scripts/pr-unblock/report-escalation.test.sh: 1407 ok, 0 not ok.node --test .github/scripts/pr-merge/clear-escalations.test.mjs: 128 pass, 0 fail.Related
#17344, docs/adr/0073-merge-dependabot-pull-requests-in-the-pr-merge-lane.md
🤖 Generated with Claude Code
https://claude.ai/code/session_01KeBVgeasNxAPMueGtzfrDM