Skip to content

pr-unblock: route dependency-fix-refused to a session builder, not a security hold #17569

Open

Description

@kyle-sexton

Problem

pr-unblock's dependency-fix-refused stop fires when a non-Dependabot commit lands on a Dependabot branch. It labels that stop with reason security and applies needs-human, which parks the pull request for the owner (for example #17344). No token, secret, account or billing exposure is involved, so the owner is not the right recipient.

Decision

The owner decided on 2026-11-19 at about 23:15Z, in the GitHub PRs session (https://claude.ai/code/session_01KeBVgeasNxAPMueGtzfrDM), answering that session's Q1: "should security-tagged automation stops wait for you when the cause is gone and no secret/account/billing exposure exists?"

Owner, verbatim: "with recommendations. Again, the security issue has to be critical, like an actual security issue"

Standing direction §10, verbatim: "Holds that guard against our own actors (path holds, trust-path holds, person-approval holds, bot-author holds, pin/repin ceremony) are friction, not security boundaries, and come off now." and "Section 3's "high/critical boundary" means only: a token or secret leaking, my accounts being compromised, or anything that bills me. Nothing else qualifies."

Decision: dependency-fix-refused routes to a session builder (needs-session), not to the owner as a security hold with needs-human. dependency-escalate-security (a real HIGH/CRITICAL risk in the update) still goes to the owner. This is distinct from the Q24 (b) Dependabot approval exit (owner-decisions.md line 34 in melodic-software/architecture), which concerns who approves a Dependabot pull request and is unchanged.

Done when

  • The reroute of dependency-fix-refused to needs-session is merged with tests.
  • dependency-escalate-security still routes to the owner.

Related

Activity

  1. added
    needs-triageNot yet classified. Floor until a type and one priority tier are set.
    on Nov 20, 2026
  2. github-actions commented on Nov 20, 2026

    @github-actions
    Contributor

    Size: Small
    Complexity: Low
    Uncertainty: Known
    Flags: none
    Blocked by: none
    Blast radius: pr-unblock escalation routing (escalation-routes.json, apply-dependency-verdict and their tests) and the pipeline docs; read by the PR pipeline lanes and the owner.
    Reversible: yes; revert the routing change.
    Open questions: none
    Understood: route the dependency-fix-refused stop to a session builder (needs-session) instead of a security hold with needs-human. dependency-escalate-security must still go to the owner. Done when the reroute is merged with tests. The issue quotes an owner decision in its body, which settles nothing for triage, but the intended outcome is exact. I found no duplicate open issue and no merged PR that already makes this change.

    Automated triage. A maintainer reviews it.

  3. removed
    needs-triageNot yet classified. Floor until a type and one priority tier are set.
    on Nov 20, 2026
  4. melodic-automation-lanes commented on Nov 20, 2026

    @melodic-automation-lanes
    Contributor

    Not admitted to the issue lane: no trusted-human acceptance criteria: a listed human must put the confirmed - [ ] criteria in the body or post them as their own comment, or, on an issue a listed human filed, intake's newest refinement comment must hold them unedited. Admission takes the issue once each of those is met, when intake triages it again (.github/actions/resolve-config/admission-rules.json).

  5. melodic-automation-lanes commented on Nov 20, 2026

    @melodic-automation-lanes
    Contributor

    Refinement. A read-only run explored this repository, searched its issues and pull requests, and read the allowed docs to draft what follows. On an issue a listed human filed, it counts as the issue's spec once posted, while unedited; it is still model text, so check it.

    Intended outcome: Route the dependency-fix-refused stop to a session builder (needs-session, fail route) instead of a security hold with needs-human, leaving dependency-escalate-security as an owner hold.

    Acceptance criteria

    • escalation-routes.json entry dependency-fix-refused has route fail and label needs-session, with no owner-reason key, matching dependency-fix-not-landed at .github/scripts/pr-unblock/escalation-routes.json:43
    • escalation-routes.json entry dependency-escalate-security still has route hold and owner-reason security
    • report-escalation.test.sh moves dependency-fix-refused from HOLD_REASONS and OWNER_REASONS into SESSION_REASONS, and the script passes
    • report-escalation.test.sh comment at lines 184-185 and 198-199 no longer calls dependency-fix-refused a trust hold the owner keeps
    • clear-escalations.test.mjs expected review-dependency non-hold list now includes dependency-fix-refused and its message at line 341 drops dependency-fix-refused from the person-hold list, and the test passes
    • A test shows dependency-fix-refused applies needs-session and not needs-human, and dependency-escalate-security still applies needs-human with owner reason security
    • apply-dependency-verdict.test.mjs assertions on escalationReason dependency-fix-refused still pass unchanged
    • pr-unblock docs (docs/conventions/pr-pipeline/README.md near line 2460, pr-run-activity.md near lines 1432 and 1451, and the CHANGELOG) describe dependency-fix-refused as a session-builder stop, not a security hold, with a CHANGELOG entry
    • Comments in apply-dependency-verdict.mjs lines 27 and 40 and the write workflow comment near line 514 do not describe the stop as a security hold
    • The repository's existing pr-unblock and pr-merge script test suites pass

    External state: none

    Related work

    Sources read

    • .github/scripts/pr-unblock/escalation-routes.json:56: dependency-fix-refused is route hold, owner-reason security
    • .github/scripts/pr-unblock/escalation-routes.json:43: dependency-fix-not-landed is the model for a fail route with label needs-session
    • .github/scripts/pr-unblock/escalation-routes.json:51: dependency-escalate-security is route hold, owner-reason security, to stay unchanged
    • .github/scripts/pr-unblock/apply-dependency-verdict.mjs:385: emits dependency-fix-refused as an invalid stop
    • .github/scripts/pr-unblock/apply-dependency-verdict.mjs:436: emits dependency-fix-refused as an escalate stop
    • .github/scripts/pr-unblock/report-escalation.test.sh:184-214: HOLD_REASONS, OWNER_REASONS and SESSION_REASONS lists and the trust-hold comment place dependency-fix-refused as a security hold
    • .github/scripts/pr-merge/clear-escalations.test.mjs:338-342: asserts the review-dependency non-hold reasons and says dependency-fix-refused holds for a person
    • .github/workflows/pr-run-activity-write.yml:725 and 1790: allowlists dependency-fix-refused as a valid reason, which stays valid under the reroute
    • docs/conventions/pr-pipeline/README.md:2460 and pr-run-activity.md:1432,1451: docs describing the dependency-fix-refused stop

    Automated refinement by the lanes App. Intake triages the issue again with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    Fields

    Work status

    needs-triage

    Priority

    medium

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions