Repository navigation
fix(pr-merge): read only the review-status names of the hosted review lanes - #14154
Conversation
… lanes Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015XWwmbdW8moDiQ5Rtgt7d5
Codex Review Summary: ❌ FailedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
claude-security-review reviewed Security review (blocking only): no security issues foundI read every hunk of all 13 changed files. I gave the trusted-path files extra scrutiny: What changed. The PR stops accepting the old status job names, Merge holds I checked. Every changed list only narrows which jobs count, so each gate holds more often, never less:
Other controls. Nothing in the diff widens who is trusted, a lane token's scope, or what untrusted text reaches a lane. It does not touch the kill switch, and it changes no plugin manifest. Babysit sync test. The test removes one case about an old name. No shipped babysit script changes, so PR context. The description contains no instructions aimed at this lane. Prior findings. The one earlier post was a summary with no line anchor, and it reported 0 findings. There is nothing to carry forward. Cost. Pull requests whose last review used the old names will need a fresh hosted review run. That spends only subscription or prepaid usage, so it is not a hold and is not counted as a finding. The prior-findings file says critical-findings: 0 |
|
claude-review reviewed Code review: PR #14154 (
|
…n the gate suites Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015XWwmbdW8moDiQ5Rtgt7d5
…d sync cases merge-holds.mjs no longer reads `pr-review / claude-review-status`, while babysit_merge_policy.py still does: the babysit plugin serves repositories whose callers still use that name. The sync case that expected both readers to carry a decision from it now fails by design, so it is removed. test_babysit_merge_cost.py keeps the Python side's coverage and merge-holds.test.mjs asserts the gate rejects it. The pr-pipeline README now names the status jobs the hold step reads. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015XWwmbdW8moDiQ5Rtgt7d5
Refs: melodic-software/ci-workflows#866
Summary
ci-workflows#1034 gave pr-review-cli.yml's status job a literal name,
review-status. #14075 then made our readers accept both the old and the new names. A real run since #1034 merged shows the new names in this repository, so this drops the old names (pr-review / claude-review-status,pr-review-security / security-review) from the three readers here.Evidence of the new names: on #14148, run 42497727048 shows
pr-review / review-statusand run 42497727273 showspr-review-security / review-status. Both started at about 16:09Z, after #1034 merged at 15:55:08Z.Fix
.github/workflows/pr-require-checks.yml: the cost-hold step and the "Require both review lanes" step now name one status job per lane..github/scripts/pr-merge/merge-holds.mjs(REVIEW_LANES) andclear-escalations.mjs(LANE_RECORDS) also name one status job per lane.docs/conventions/pr-pipeline/README.md: "Both lanes review the head" names the new status jobs.test_merge_holds_sync.py: drops the "a status job named as pr-review.yml names it" case. It asserted that babysit's Python cost decision andmerge-holds.mjsagree on the old name; they now differ on purpose, because babysit keeps reading the old name (next bullet). Babysit's handling stays tested intest_babysit_merge_cost.py, the gate's rejection inmerge-holds.test.mjs.pr-review / claude-review-status.Effect: a pull request whose last hosted review ran before #1034 merged no longer counts that review. It needs a fresh review run before
ci-status, the cost hold or the escalation clear will read it.Verification
merge-holds.test.mjs,clear-escalations.test.mjsandclear-escalations-recheck.test.mjs.enable-auto-merge.test.mjs's cost-hold fixture now uses the new name.node --testfails 3 tests. With the change,node --test .github/scripts/pr-merge/*.test.mjs .github/scripts/maintenance-reconcile-lost-runs/*.test.mjspasses all 1116.test_merge_holds_sync.py21 tests OK;engine.test.shexit 0;check-changelog-fragments.sh --checkclean.pr-require-checks.ymlis clean.Related
🤖 Generated with Claude Code
https://claude.ai/code/session_015XWwmbdW8moDiQ5Rtgt7d5