Skip to content

docs(outage-posture-audit): record the ci-workflows fixes for the hosted review and ci-status composites - #14148

Merged
kyle-sexton merged 2 commits into
mainfrom
docs/outage-audit-ci-workflows-1007
Nov 8, 2026
Merged

kyle-sexton merged 2 commits into
mainfrom
docs/outage-audit-ci-workflows-1007

Conversation

@kyle-sexton

@kyle-sexton kyle-sexton commented Nov 8, 2026 •

Copy link
Copy Markdown
Member

Refs: melodic-software/ci-workflows#1007

Summary

The outage-posture audit still listed two gaps whose code lives in ci-workflows. Both are now fixed there, so this updates the audit to say so.

Fix

In docs/outage-posture-audit.md:

  • The "Remaining, outside this repository" paragraph now describes the fixes, with file:line on ci-workflows main at 96ea8d4c:
    • ci-workflows#1026: the check-contract and aggregate-results composites now send each call at most 3 times, and repeated GETs send If-None-Match (.github/actions/pr-require-checks/gh-api.sh:234, :222, :123).
    • ci-workflows#1033: the hosted review leg in pr-review-cli.yml resends failed reads (:911, :1292). When it cannot read the diff base, it holds green with a held: notice (:1336, :7659).
  • Element 1 changes from gap to met for pr-review and pr-review-security, which call pr-review-cli.yml@main.
  • pr-require-checks element 1 stays a gap. This repository pins its composites to check-contract@2476d5dd and aggregate-results@226dad32, and both pins are older than fix(disk-hygiene): reason about volume-root rejection instead of blanket-denying non-OS drives #1026, so the fix takes effect only once those pins move.

Verification

  • markdownlint-cli2 docs/outage-posture-audit.md: 0 issues.
  • I read each cited line at ci-workflows 96ea8d4c (git grep on origin/main).

Related

🤖 Generated with Claude Code

https://claude.ai/code/session_015XWwmbdW8moDiQ5Rtgt7d5

…ted review and ci-status composites

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015XWwmbdW8moDiQ5Rtgt7d5
@chatgpt-codex-connector

Copy link
Copy Markdown
Codex Review Summary: ❌ Failed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ❌ Failed 2026-11-08T16:01:19.001376Z
We couldn’t complete this review. Comment @codex review to try again.
d9d148b PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@github-actions

github-actions Bot commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

claude-security-review reviewed c2005ecd2e2bad70b9bdecc0eb984d2914e8b1c8: read 1 of 1 changed file(s); 0 finding(s), 0 as inline comments.

Security review: no security issues (incremental, blocking only)

I read the whole incremental diff since d9d148b1. It touches one file, docs/outage-posture-audit.md, in three hunks:

  • In the pr-require-checks verdict table, element 1 goes back from met to gap. The Why cell now says what is left: the pinned composites (:5044, :6908) predate the ci-workflows#1026 fix.
  • In the "Remaining, outside this repository" paragraph, one sentence is reworded. A new sentence says this repository pins check-contract@2476d5dd and aggregate-results@226dad32, which are older than 03d2e3dc, so the fix reaches ci-status only once those pins move.

Why there is nothing to report:

  • This file is audit documentation. It matches none of the TRUSTED PATHS: globs and is not an instruction surface: it is not a CLAUDE.md, a rules file, a skill or agent body, or a hook list.
  • No workflow, action, script, manifest, pin or gate changes. The new text only describes the existing pins; it does not move them. No trust control, token scope, kill switch or merge hold is touched.
  • The change makes the audit more conservative: element 1 goes back to gap and an open item is recorded. It removes no rule or control.

Embedded text: none. Nothing in the PR context tells the lane to pass, skip or drop anything.

Prior findings: the summary posted at d9d148b1 held no findings, so nothing carries over. This review was blocking only (blocking only: yes), so it reports only CRITICAL and IMPORTANT findings, and there are none.

critical-findings: 0

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

claude-review: 1 inline finding(s) on d9d148b1e9e70d38e783bfc0757eaf8bc0db0a4f; the summary is in this lane's pull request comment.

claude-lane: claude-review

Comment thread docs/outage-posture-audit.md Resolved
@github-actions

github-actions Bot commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

claude-review reviewed c2005ecd2e2bad70b9bdecc0eb984d2914e8b1c8: read 1 of 1 changed file(s); 0 finding(s), 0 as inline comments.

Code review: PR #14148, incremental (d9d148b → c2005ec), blocking only

This review is blocking only. The prior-findings file says blocking only: yes, so this pass reports only blocking findings and drops advisory ones. It is an incremental review: I read every hunk of the one file in scope, docs/outage-posture-audit.md.

Earlier finding is resolved. Last round's inline finding asked whether this repository's pinned composites contain ci-workflows#1026 (thread). This push takes the second fix that thread offered:

  • The pr-require-checks element 1 row (line 171) goes back to gap. It now says ci-workflows#1026 fixed the composites' reads, but the pins at :5044 and :6908 predate that fix.
  • I checked both pin lines: they match the uses: lines at pr-require-checks.yml:5044 (check-contract@2476d5dd…) and :6908 (aggregate-results@226dad32…).
  • The Remaining bullet now says the fix reaches ci-status only when both pins move to a commit that contains 03d2e3dc. That matches the row.

Not verified. Two claims rest on the author's word, since I have no access to ci-workflows here:

  • that both pinned SHAs predate ci-workflows#1026;
  • that 03d2e3dc is the commit that carries the fix.

If either pin already contains it, element 1 could be met. Either way, the gap verdict is the cautious reading.

Other notes

No blocking findings on this head.

…il the composite pins move

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015XWwmbdW8moDiQ5Rtgt7d5
@kyle-sexton
kyle-sexton added this pull request to the merge queue Nov 8, 2026
Merged via the queue into main with commit 8fa2f41 Nov 8, 2026
63 checks passed
@kyle-sexton
kyle-sexton deleted the docs/outage-audit-ci-workflows-1007 branch November 8, 2026 17:13
@github-actions github-actions Bot added the merge-path: owner-agent Post-merge accounting record (README.md, Merge paths) label Nov 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge-path: owner-agent Post-merge accounting record (README.md, Merge paths)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant