Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
---
bump: patch
---

### Fixed

- `prerequisites.json` caps the `python` entry with `below: "3.14"`, so a host whose only Python is 3.14 is reported outdated instead of ready. The install hook runs only on Python 3.12 or 3.13.
22 changes: 21 additions & 1 deletion lib/prerequisites.test.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,17 @@ import path from "node:path";
import process from "node:process";
import { after, describe, test } from "node:test";
import { fileURLToPath } from "node:url";
import { compareVersions, KINDS, loadManifest, main, NEEDS, report, validateManifest, which } from "./prerequisites.mjs";
import {
compareVersions,
detectEntry,
KINDS,
loadManifest,
main,
NEEDS,
report,
validateManifest,
which,
} from "./prerequisites.mjs";

const here = path.dirname(fileURLToPath(import.meta.url));
const checker = path.join(here, "prerequisites.mjs");
Expand Down Expand Up @@ -897,6 +907,16 @@ describe("shipped plugin manifests", { skip: !posix && "the stub tools are POSIX
assert.equal(r.out, "");
});
}

// explainer-video's launcher runs only the Pythons its scripts/pydeps.json lists (3.12 and 3.13).
test("explainer-video: the python entry passes 3.13 and reports 3.14 outdated", () => {
const { manifest } = loadManifest(path.join(pluginsDir, "explainer-video"));
const python = manifest.requires.find((e) => e.id === "python");
const at = (v) =>
detectEntry(python, { env: { PATH: bin({ python3: `echo "Python ${v}"` }) }, platform: process.platform, cwd: work });
assert.equal(at("3.13.5").status, "present");
assert.equal(at("3.14.0").status, "outdated");
});
});

describe("command line", () => {
Expand Down
2 changes: 1 addition & 1 deletion plugins/explainer-video/prerequisites.json
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
"for": ["hook:install-python-deps.sh", "skill:produce", "skill:check"],
"detect": {
"any": ["python3.13", "python3.12", "python3", "python"],
"version": { "args": ["--version"], "pattern": "Python ([0-9.]+)", "min": "3.12" }
"version": { "args": ["--version"], "pattern": "Python ([0-9.]+)", "min": "3.12", "below": "3.14" }
},
"degrade": "Without Python 3.12 or 3.13 ManimCE is not installed and /explainer-video:produce cannot render. Python 3.14 is not supported.",
"install": { "docs": "https://www.python.org/downloads/", "brew": "python@3.13", "winget": "Python.Python.3.13", "apt": "python3.13" },
Expand Down
Loading