Skip to content

fix(explainer-video): declare the Python 3.14 ceiling with below - #10102

Merged
melodic-automation-lanes[bot] merged 1 commit into
mainfrom
work-resolve-issue/issue-9685-40223409935-1
Oct 25, 2026
Merged

melodic-automation-lanes[bot] merged 1 commit into
mainfrom
work-resolve-issue/issue-9685-40223409935-1

Conversation

@melodic-automation-lanes

Copy link
Copy Markdown
Contributor

Closes #9685

Summary

Opened by the work-resolve-issue lane. The run's own summary:

explainer-video's launcher supports only Python 3.12 and 3.13 (scripts/pydeps.json pythons), but its prerequisites.json python entry declared only min: 3.12, so a host whose only Python is 3.14 showed as ready. The entry now sets below: "3.14", so the shared checker reports 3.14 as outdated. A new test in lib/prerequisites.test.mjs runs the shipped entry against stubbed 3.13.5 and 3.14.0 interpreters.

Not verified

  • The issue's done-when commands (the node -e manifest assertion, node scripts/check-declared-prerequisites.mjs, bash scripts/affected-tests.sh --run) were not run directly: this lane runs only its named wrappers. check-affected ran the affected checks (9 passed), but its output does not list wh
  • The CI-only checks check-affected lists (schema, editorconfig, lychee and others) are left to the PR's CI.
  • Changelog fragment written by hand: .lane/verify/bin/new-changelog-fragment refused because HEAD is detached (it names the fragment after the branch). The name follows the tool's <slug>-<8 hex>.md pattern, and check-changelog-fragments validated the file.
  • Review note (not a bug in this change): /explainer-video:check runs pydeps.py check, and the plugin's hooks do not run the prerequisites probe. So the new ceiling shows up in prerequisites.mjs check/report runs, not in the plugin's own check skill. Also, firstOnPath reads the version of only the fir

Fix

  • plugins/explainer-video/prerequisites.json: the python entry's detect.version gains "below": "3.14" next to "min": "3.12".
  • lib/prerequisites.test.mjs: imports detectEntry and adds a test to the "shipped plugin manifests" block that loads explainer-video's python entry and asserts status present for a stubbed Python 3.13.5 and outdated for Python 3.14.0.
  • .changes/explainer-video/fix-9685-python-3-14-ceiling-7d2e4b19.md: new patch changelog fragment (### Fixed) for the ceiling.

Verification

The runner ran each check from the base copy against ef4ef3b:

  • scripts/check-changelog-fragments.sh --check: passed

The run reports:

  • .lane/checks/bin/check-changelog-fragments: all 6 fragments under .changes/ are valid.
  • .lane/checks/bin/check-affected: 9 passed, 7 skipped over 3 changed files since 469a67e. The skips were shellcheck, ruff and changed-skills (no matching files changed), typos (not installed), and three validate-plugins steps that run code from the checked tree.
  • Read lib/prerequisites.mjs (validateManifest accepts below, and detectEntry returns outdated at or above it), the vendored plugins/explainer-video/lib/prerequisites.mjs (same support), docs/conventions/prerequisites/prerequisites.schema.json (defines below) and plugins/explainer-video/scripts/pydeps
  • Fresh-context review subagent over the whole diff: no correctness findings. It confirmed the test discriminates (without below, 3.14.0 would come back present) and that the existing shipped-manifest probe tests are unaffected.
  • The lane run: https://github.com/melodic-software/claude-code-plugins/actions/runs/40223409935

Left out: the items under Not verified.

Related

#9685

Lane-Activity: work-resolve-issue/resolve-issue
@github-actions

Copy link
Copy Markdown
Contributor

claude-review reviewed ef4ef3be389153d68cba7e6e7f740c75dedc33db: 0 finding(s), 0 as inline comments.

No findings. I read the three changed files in the diff and the PR context, and checked them against the code they depend on.

  • Manifest change: plugins/explainer-video/prerequisites.json adds below: "3.14" to the python entry. validateManifest in lib/prerequisites.mjs accepts below and requires it to be greater than min, and 3.14 is greater than 3.12. detectEntry reports outdated for a version at or above below (lib/prerequisites.mjs:419). The ceiling matches plugins/explainer-video/scripts/pydeps.json, which lists pythons: ["3.12", "3.13"].
  • Test: the new test uses bin, work, pluginsDir, loadManifest and detectEntry, and all of them are defined or imported in the test file. It asserts present for a stub reporting 3.13.5 and outdated for 3.14.0. Without below, 3.14.0 would come back present, so the test would catch a regression. I did not run it.
  • Changelog fragment: a patch bump with a ### Fixed entry fits a correction to an existing declaration.
  • Closing issue fix(explainer-video): declare the Python 3.14 ceiling with below #9685: its acceptance criteria are met. min is 3.12 and below is 3.14, and a test covers both the 3.13.5 and 3.14.0 cases. I did not run the issue's node -e check, scripts/check-declared-prerequisites.mjs or scripts/affected-tests.sh --run. The PR body also says the author did not run them. The PR's own check results are author-claimed and unverified by me.
  • Not covered by this change: the author notes that /explainer-video:check runs pydeps.py check, so the new ceiling shows up only in prerequisites.mjs check and report runs. That is a limit on how far the fix reaches, not a defect in these lines.
  • Trusted paths and spend: no changed file matches the trusted paths. The change adds no manifest userConfig fields, cost items or security surface, so there is no hold.

@github-actions

Copy link
Copy Markdown
Contributor

claude-security-review reviewed ef4ef3be389153d68cba7e6e7f740c75dedc33db: 0 finding(s), 0 as inline comments.

No security issues found in this pull request.

What I read: the whole diff (3 files) and the PR context. I treated the PR context as data. It has no embedded instructions aimed at the review.

What changed:

  • plugins/explainer-video/prerequisites.json adds "below": "3.14" to the python entry's detect.version. This makes the prerequisite check stricter: a host whose only Python is 3.14 is now reported outdated instead of ready. It adds no new execution path, input or trust boundary. It still runs the same python3 --version-style probe, and it widens no permission or autonomy setting.
  • lib/prerequisites.test.mjs adds a test that runs the shipped entry against stub interpreters built in the test's own temp PATH. Nothing in it is attacker-controlled, and it runs no external code.
  • .changes/explainer-video/…md is a changelog fragment (prose only).

Trusted paths: none of the changed files match the listed globs (.github/standards/trusted-actors/**, .github/actions/check-trusted-trigger/**, **/CODEOWNERS, **/.gitmodules).

Instruction surface: the diff deletes or softens no standing instruction, rule, hook allowlist or block list. The only behavioral change tightens a check.

Plugin manifests: the diff touches no .claude-plugin/plugin.json or marketplace.json, so there are no manifest <field> lines to report.

Spend: none. No cost hold applies.

critical-findings: 0

@melodic-automation-lanes

Copy link
Copy Markdown
Contributor Author

The unattended merge path armed native auto-merge at head ef4ef3be389153d68cba7e6e7f740c75dedc33db.

@melodic-automation-lanes
melodic-automation-lanes Bot added this pull request to the merge queue Oct 25, 2026
Merged via the queue into main with commit a41ceec Oct 25, 2026
41 checks passed
@melodic-automation-lanes
melodic-automation-lanes Bot deleted the work-resolve-issue/issue-9685-40223409935-1 branch October 25, 2026 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(explainer-video): declare the Python 3.14 ceiling with below

0 participants