Repository navigation
Read Brig Gen as one title; read Hon as a given name under a Chinese choice (#999) - #1035
Merged
Merged
Conversation
…choice (#999) `brig` joins en.toml as Brigadier written short, a title only inside a title phrase (a rare given name), attaching to `gen`, `general` and `sir`: `Brig Gen Mark Kimmitt` and a trailing `BRIG. GEN.` read the title, a bare `Brig` the given name as before. `hon`, the British style and a Cantonese given name, keeps the title by default; zh.toml gives it a given reading off by default, which a Chinese choice turns on. No words-to-spare count separates the two: a two-syllable Cantonese given name leaves two words after it, as the commonest titled name does. Under the choice the formal styles keep the title through partners (`Rt Hon`, `Hon Mrs`, `Hon Justice`), the written-short mark (`SMITH, JOHN HON.`) and a new rules/H9 clause: a style that may be a given name has its partner in the article before it (`The Hon John Smith`), which moves `The Grace Smith` to title 'The Grace' in the default. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The design-docs review found the first build's article clause moving seven gated styles in the default (`The Sheikh Mohammed bin Rashid` read title 'The Sheikh', reversing 2.7's epithet reading) and every comma shape (`John Smith, the Sheikh`), against rules/H9's epithet bullet. Written short, it reaches `hon` alone and moves no default reading. The decisions record moves the two Standing lines out of the Log, gives the words-after-Hon table its recipe, counts FEC's 14 as 6 names and 8 styles (3 past a second comma), records the six-word ceiling on hon's partners and the Hon Dr / Hon Ms cost, and corrects an example and a count. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Pin what no test held: the article clause's written-short guard (`The Sheikh Mohammed bin Rashid` and `The Grace Smith` keep the epithet), brig's mark and its `general` and `sir` partners (`John Smith Brig.`, `Brig General John Smith`, `Brig Sir John Smith`), and hon's `lady` partner; the zh test now asserts whole readings and the one-comma cost (`John Smith, Hon`), recorded in decisions/H9 and the docs with the styled shape `The Hon Hon Wah Chan`. Correct the prose: `rt` is no modifier, three words after Hon is the commonest titled shape, 10 of UKEC's 11 are bare; and name the article partner in title_readings' docstring, `_STYLE_ARTICLES`, `_KIND_FIELDS`, AGENTS.md, the vocab README and rt's note. locales.rst says the zh pack makes no choice of languages. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows #1029 (
Gen). This finishes the abbreviated titles that are also given names:Brigin the default,Honopted into by a Chinese choice of languages.Brig
brig(Brigadier written short) was in no vocabulary file, soBrig Gen Mark Kimmittread givenBrig, middleGen Mark. It joins en.toml as a rank written short with a rare-given-name reading (US SSA 72 births). That makes it a title only inside a title phrase (rules/H9), pairing withgen,generalandsir.No reading moves from a title to a name. Of 28 local-corpus texts holding the word, 13 move:
BRIG. GEN., and JRC's 2Brig Gen.The one side effect: JRC-Names has 1 person now read apart, a brigadier written both
Brig Gen Mark KimmittandBrig Mark Kimmitt.Hon
Honis the British style "the Honourable" and also a Cantonese given name. No position or count separates the two. Here are the words after aHonopening the name:A two-syllable Cantonese given name leaves two words after
Hon, the commonest titled shape too. So a words-to-spare rule misreads about 330 names at "two or more" and about 52 at "three or more".Decided: the default keeps the title. zh.toml gives
honagivenreading writtendefault = false, which a Chinese choice turns on:Locale(..., languages=frozenset({"zh"})), orzh-HK. That is the same mechanism as ne.toml'sguruunder a Nepali choice.locales.ZHitself makes no choice of languages, since its contract is to change only Han-bearing names.Under the choice, the formal styles keep the title:
Rt Hon, through a partner (rtattaches tohon).Hon Mrs,Hon Mr,Hon Lord,Hon Lady,Hon SirandHon Justice, throughhon's own partners.SMITH, JOHN HON., becausehoncarries the written-short mark.The Hon, through one new rules/H9 clause: a style that may be a given name, written short, has its phrase partner in the article before it.The clause reaches
honalone and moves no default reading. The first build had read every gated style this way, and review found it movingThe Sheikh Mohammed bin RashidandJohn Smith, the Sheikhagainst H9's epithet bullet.Measured under the choice, against the default on this tree: 158 of 1,093
hontexts move.Hon David Layton, PSC ~11, FEC 5 bare after a family comma and 3 past a second comma.Hong Kong writes legislators
Hon Tommy Cheung, so the cost reaches Chinese data too; it is recorded.honnames six partner words rather than a kind. A kind made phrases with the gated nobles (hon sultan), which started atitle-or-namereport onSultan Hassanal Bolkiah. A longer list also overflows what the 2.x translation's refusal message shows, which would cut its offered code short (... 62 more), and that code would not run. The cost is thatHon DrandHon Msread givenHonunder the choice.Measured in the default
measure.py --baseagainst masterd97211a3moves only the 13brigtexts:hontexts move.Docs
Brig Genexample.brigandhonentries with Standing lines and recipes.Hon.Brigmerged into the Maj/Gen one; a new one forHon.zhchoice in tests/v2/test_parser.py.Review
Two design-docs review rounds, on the change and on its fix commit. Everything they found is fixed in the later commits.
A third round (code, test-coverage and comment reviews) found no code defect. It found untested behavior and stale or inaccurate prose, all fixed in the last commit:
The Sheikh Mohammed bin Rashidkeeps the epithet),brig's trailing mark and itsgeneralandsirpartners, andhon'sladypartner. A mutation run against each one now fails.zhtest asserts whole readings.John Smith, Honreads givenHon.Checks run: full suite, mypy, ruff, Sphinx doctest.
🤖 Generated with Claude Code