Repository navigation
Read Gen as a given name outside a title phrase (#999) - #1029
Merged
Merged
Conversation
`gen` (General written short) is also a Japanese and Chinese given name: 680 ORCID given boxes and 274 US-patent inventors open with it. It gains a dated given reading and the written-short mark, as `maj` did, so `Gen Goto` reads given 'Gen', reported title-or-name, while `Gen.`, a trailing `GEN.` and the rank phrases keep the title. The ranks and offices that stand before General (`lt`, `lieutenant`, `brigadier`, `adjutant`, `attorney`, `surgeon`, `secretary`, `governor`, `gov`, `solicitor`) attach to `gen`, so `Lt Gen John Smith` and `Attorney Gen Smith` keep their phrase. Measured against ba1ac32 over the local corpora: 134 texts move, about 74 given names fixed, about 43 bare ranks now read as given names (rules/H9's Accepted clause), about 17 unclear. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Seven ranks and offices written before General lost their phrase: `colonel` and `col` (Colonel General), `director`, `dir`, `comptroller`, `vicar` and `advocate` (Judge Advocate General) now attach to `gen`, and `gen` and `maj` attach to `sir`, so `Gen Sir Nick Carter` keeps title 'Gen Sir'. The release bullet no longer promises every rank written together and states the `and` shape (`Gen. and Mrs. John Smith`), which decisions/H9 records as a cost; its entry gives the 22 words and the 384-reading grid their recipes, counts PatentsView's 263 records as 274 inventors, and splits the 74 fixes into 65 given names and 9 post-nominals. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Nov 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows #1027 (#999,
Maj).Gen, General written short, is also a Japanese and Chinese given name, andparse()read it as a title wherever it opened a name. It now reads the wayMajdoes: a title only inside a title phrase (rules/H9, the title phrase), and the trailing title when written short with its period (rules/H5, the trailing title run).Why Gen, and why not the others
I checked 22 rank, office and clerical abbreviations in
TITLESagainst the fielded corpora, where people split their own names into boxes. Onlygenandhonopen the given box as a name. The rest appear there only as titles typed into the box (Lt Col …,Fr. …,Sr …,Mgr. …).gen's bearers:Gen(China 155, Japan 100), 647 of them the whole box.hon, the Cantonese given name, is left for its own decision. UK registers write the style "the Honourable" bare at the head.The phrases
A gated word is a title only with a partner, so every rank and office written before
Genmust attach to it, or its phrase splits. These now attach togen:lt,lieutenant,brigadier,colonel,col,adjutantattorney,surgeon,secretary,governor,gov,solicitordirector,dir,comptroller,vicar,advocategenandmajalso attach tosir.maj,majorandchiefalready attached.nameparser/vocab/AGENTS.md's check from #1027 is what this list follows.Pre-existing gaps, not this change's:
Brig Gen,Insp GenandLt-Genalready misread on master, becausebrig,inspand hyphenated ranks are not title words.Measured
Against master
ba1ac328, over every local-corpus text holdinggen,maj,siror a partner word (3,639 texts). 134 move, allgentexts:ADC Gen, which read titleGeneral Sir Gen.Gen X-ers,Gen Con).The partners add no move.
measure.py --basegives the same moves per corpus. CLDR, GND and cz-candidates agreement don't move. Box agreement: orcid 30 progress, patentsview 16, psc 6, none regressing. JRC spelling consistency: 3 persons now alike, 0 apart.The comma-shape and name-order sweep (384 readings) moves the same shapes
maj's did. Only the partner phrases differ.Costs recorded
In rules/H9's Accepted clause and decisions/H9:
Gen Pinochet), as withMajandDean.andjoins as a given name (Gen. and Mrs. John Smith), per H9's connective precedence.Gen. Smith, Johnkeeps familyGen. Smith, since H6 (a title before a family comma) peels by vocabulary only.Sir Gen Gotoreads titleSir, givenGen; the British orderGen Sirkeeps its title.Docs
genentry and Standing line; themajStanding pointer is disambiguated.Gen Hoshino) that the default now reads the same way. A strict-choice test row moved toCapt Hoshinofor the same reason.Not done here: docs/migrate.rst's "Changed in 3.0" list has no per-change entries yet for this cycle; that's left for the release sweep.
Review
Two design-docs review rounds, on the change and on its fixes. Everything they found is fixed in the later commits.
Checks run: full suite, mypy, ruff, Sphinx doctest and html,
build.py --check.🤖 Generated with Claude Code