Skip to content

feat(videostitcher): update other samples using feedback from #9412 - #9438

Merged
irataxy merged 3 commits into
GoogleCloudPlatform:mainfrom
irataxy:feedback
Aug 12, 2024
Merged

feat(videostitcher): update other samples using feedback from #9412#9438
irataxy merged 3 commits into
GoogleCloudPlatform:mainfrom
irataxy:feedback

Conversation

@irataxy

@irataxy irataxy commented Aug 6, 2024

Copy link
Copy Markdown
Contributor

Description

  • Add method comments
  • Use try with resources
  • Remove videoStitcherServiceClient.close()
  • Return the response and use it in test cases for assertion
  • Combine related tests into a single file rather than using individual files per test case
  • Setup and tear down should be done once in a test lifecycle
  • Please merge this PR for me once it is approved

@irataxy
irataxy requested review from a team and yoshi-approver as code owners August 6, 2024 16:33
@product-auto-label product-auto-label Bot added api: videostitcher Issues related to the Video Stitcher API API. samples Issues that are directly related to samples. labels Aug 6, 2024
Sita04
Sita04 approved these changes Aug 12, 2024
View reviewed changes

@Sita04 Sita04 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for refactoring the existing samples. LGTM.
Please address the few nits before merging.

Comment thread media/stitcher/src/test/java/com/example/stitcher/CdnKeyTest.java Resolved
Comment thread media/stitcher/src/test/java/com/example/stitcher/LiveConfigTest.java Resolved
Comment thread media/stitcher/src/test/java/com/example/stitcher/LiveSessionTest.java Resolved
Comment thread media/stitcher/src/test/java/com/example/stitcher/SlateTest.java Resolved
@irataxy
irataxy merged commit ace5e5b into GoogleCloudPlatform:main Aug 12, 2024
@irataxy
irataxy deleted the feedback branch August 12, 2024 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Sita04 Sita04 Sita04 approved these changes
@yoshi-approver yoshi-approver Awaiting requested review from yoshi-approver yoshi-approver is a code owner

Assignees

@Sita04 Sita04

Labels

api: videostitcher Issues related to the Video Stitcher API API. samples Issues that are directly related to samples.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@irataxy @Sita04 @kweinmeister