Skip to content

feat(videostitcher): add VOD config samples and tests - #9412

Merged
irataxy merged 7 commits into
GoogleCloudPlatform:mainfrom
irataxy:vod
Jul 30, 2024
Merged

feat(videostitcher): add VOD config samples and tests#9412
irataxy merged 7 commits into
GoogleCloudPlatform:mainfrom
irataxy:vod

Conversation

@irataxy

@irataxy irataxy commented Jul 12, 2024

Copy link
Copy Markdown
Contributor

Description

Fixes b:347726038

  • Please merge this PR for me once it is approved

@irataxy
irataxy requested review from a team and yoshi-approver as code owners July 12, 2024 21:02
@snippet-bot

snippet-bot Bot commented Jul 12, 2024 •
edited
Loading

Copy link
Copy Markdown

Here is the summary of changes.

You are about to add 5 region tags.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label Bot added samples Issues that are directly related to samples. api: videostitcher Issues related to the Video Stitcher API API. labels Jul 12, 2024
@minherz minherz removed their assignment Jul 15, 2024
Sita04
Sita04 requested changes Jul 17, 2024
View reviewed changes

@Sita04 Sita04 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the samples!

Comment thread media/stitcher/src/main/java/com/example/stitcher/CreateVodConfig.java Resolved
Comment thread media/stitcher/src/main/java/com/example/stitcher/CreateVodConfig.java Resolved
Comment thread media/stitcher/src/main/java/com/example/stitcher/CreateVodConfig.java Resolved
Comment thread media/stitcher/src/main/java/com/example/stitcher/CreateVodConfig.java Resolved
Comment thread media/stitcher/src/main/java/com/example/stitcher/CreateVodConfig.java Resolved
Comment thread media/stitcher/src/main/java/com/example/stitcher/CreateVodConfig.java Resolved
Comment thread media/stitcher/src/main/java/com/example/stitcher/CreateVodSession.java Resolved
Comment thread media/stitcher/src/main/java/com/example/stitcher/ListVodConfigs.java Resolved
Comment thread media/stitcher/src/test/java/com/example/stitcher/CreateVodConfigTest.java Resolved
@Sita04 Sita04 self-assigned this Jul 17, 2024
@Sita04 Sita04 changed the title feat: add VOD config samples and tests feat(videostitcher): add VOD config samples and tests Jul 17, 2024
irataxy and others added 5 commits July 17, 2024 13:18
@irataxy @Sita04
Update media/stitcher/src/main/java/com/example/stitcher/CreateVodCon…
2df4f4a 
…fig.java

Co-authored-by: Sita Lakshmi Sangameswaran <sitalakshmi@google.com>
@irataxy @Sita04
Update media/stitcher/src/main/java/com/example/stitcher/CreateVodCon…
fc8bc56 
…fig.java

Co-authored-by: Sita Lakshmi Sangameswaran <sitalakshmi@google.com>
@irataxy @Sita04
Update media/stitcher/src/main/java/com/example/stitcher/ListVodConfi…
b77d0f8 
…gs.java

Co-authored-by: Sita Lakshmi Sangameswaran <sitalakshmi@google.com>
Nick Cook
address feedback and refactor VOD tests (configs and sessions)
4846ad7
Nick Cook
update local var to test var
e2124fe
@irataxy
irataxy requested a review from Sita04 July 18, 2024 22:07
Sita04
Sita04 requested changes Jul 23, 2024
View reviewed changes
Comment thread media/stitcher/src/test/java/com/example/stitcher/VodConfigTest.java Resolved
Comment thread media/stitcher/src/test/java/com/example/stitcher/VodConfigTest.java Resolved
Comment thread media/stitcher/src/test/java/com/example/stitcher/VodSessionTest.java Resolved
@irataxy
irataxy requested a review from Sita04 July 27, 2024 03:18
@irataxy
irataxy merged commit 7c5bf8d into GoogleCloudPlatform:main Jul 30, 2024
@irataxy
irataxy deleted the vod branch July 30, 2024 21:50
irataxy added a commit that referenced this pull request Aug 12, 2024
@irataxy
feat(videostitcher): update other samples using feedback from #9412 (#…
ace5e5b 
…9438)

* feat(videostitcher): update other samples using feedback from #9412

* fix checkstyle errors

* retain original year for copyright
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@minherz minherz minherz left review comments
@Sita04 Sita04 Sita04 approved these changes
@yoshi-approver yoshi-approver Awaiting requested review from yoshi-approver yoshi-approver is a code owner

Assignees

@Sita04 Sita04

Labels

api: videostitcher Issues related to the Video Stitcher API API. samples Issues that are directly related to samples.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@irataxy @minherz @Sita04