Support bumper sensors in Gazebo#99
Conversation
jacobperron
left a comment
There was a problem hiding this comment.
Thanks for the additions!
See my feedback below.
|
|
||
| ## Simulation | ||
|
|
||
| The package `create_gazebo` has a launch file with a minimal simulation example of the Create robots. |
There was a problem hiding this comment.
I have mixed feelings about adding a simulation-specific package. The package is not providing any custom simulation plugins or configuration; it is simply an example launch file and rviz config file. I think it makes more sense to simply move those into create_bringup (which is the package meant for example launch/config files). While I think having the examples are nice, it technically introduces a runtime dependency on Gazebo, which I'd rather avoid.
It might be best to keep these examples in a separate repository.
|
Hi @jacobperron, sorry for the late response and thanks for your comments. I have made the recommended changes. |
|
Thanks for the contribution! |
Description
versionincreate_description/urdf/create_base.urdf.xacro.turtlebot3_gazebo.This PR is connected to #76.
Test configuration
ROS version: Noetic