Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #78 +/- ##
==========================================
+ Coverage 83.13% 83.34% +0.21%
==========================================
Files 25 25
Lines 2970 3014 +44
Branches 448 452 +4
==========================================
+ Hits 2469 2512 +43
Misses 371 371
- Partials 130 131 +1
Continue to review full report at Codecov.
|
StefH
requested changes
Apr 30, 2017
Collaborator
StefH
left a comment
There was a problem hiding this comment.
Looks good.
Please add 1 small exception test like https://github.com/StefH/System.Linq.Dynamic.Core/blob/master/test/System.Linq.Dynamic.Core.Tests/QueryableTests.Join.cs#L153
| public partial class QueryableTests | ||
| { | ||
| [Fact] | ||
| public void GroupJoin() |
Collaborator
There was a problem hiding this comment.
Also add a negative test (throws exception) like https://github.com/StefH/System.Linq.Dynamic.Core/blob/master/test/System.Linq.Dynamic.Core.Tests/QueryableTests.Join.cs#L153
StefH
approved these changes
Apr 30, 2017
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.