Fix New() support for Type + Fix GroupJoin() not working when using Linq-To-Entities#207
Conversation
Codecov Report
@@ Coverage Diff @@
## master #207 +/- ##
==========================================
+ Coverage 82.44% 82.56% +0.12%
==========================================
Files 37 37
Lines 3685 3694 +9
Branches 507 508 +1
==========================================
+ Hits 3038 3050 +12
- Misses 499 501 +2
+ Partials 148 143 -5
Continue to review full report at Codecov.
|
StefH
left a comment
There was a problem hiding this comment.
Tests fail.
Error message like:
'System.Linq.Dynamic.Core.Tests.QueryableTests+Example+NestedDto+NestedDto2' not Found
'System.Linq.Dynamic.Core.Tests.QueryableTests+Example+NestedDto' not Found
| @@ -1,5 +1,6 @@ | |||
| using System.Collections; | |||
| using System.Collections.Generic; | |||
| using System.Data.Entity.Infrastructure; | |||
There was a problem hiding this comment.
This namespace is not available in the dotnet core version from the tests, so this fails.
|
I had some tough time making tests work in my local environment. So here is the deal with New() supporting loading any Type:
Future support for generics, or even class names with assembly names, requires a revision of the parsers, which is unfortunately too disruptive now. With the proposed changes, you will now be able to New() any Type or Nested type using it's full name, but not generics. You also cannot specify the assembly name. |
|
I see your points. Actually I've taken your branch and added a new branch in which I extend the I'll add you as reviewer to the PR once it's ready... |
Fixes #204 and partially fixes #206.