Skip to content

Fix deprecated calls to curl (move to curl MIME API)#69

Merged
melroy89 merged 5 commits into
masterfrom
fix_deprecated_methods_curl
Dec 14, 2023
Merged

Fix deprecated calls to curl (move to curl MIME API)#69
melroy89 merged 5 commits into
masterfrom
fix_deprecated_methods_curl

Conversation

@melroy89

Copy link
Copy Markdown
Collaborator

Migrating away from the deprecated curl_formadd to the new libcurl MIME API.

@vasild Could you please review this PR? It's a important one (I kept the old code for your reference, I will remove this before merge this PR)/

See "Http posting" heading: https://curl.se/libcurl/c/libcurl-tutorial.html#HTTP

Resolves: https://gitlab.melroy.org/libreweb/libreweb-browser/-/jobs/15893#L130

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Attention: 19 lines in your changes are missing coverage. Please review.

Comparison is base (535a1e3) 57.49% compared to head (7ce8722) 55.16%.

Files Patch % Lines
src/http/transport-curl.cc 32.14% 0 Missing and 19 partials ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #69      +/-   ##
==========================================
- Coverage   57.49%   55.16%   -2.33%     
==========================================
  Files           2        2              
  Lines         447      455       +8     
  Branches      206      219      +13     
==========================================
- Hits          257      251       -6     
  Misses         17       17              
- Partials      173      187      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vasild vasild left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, you can drop the old commented code and squash.

Comment thread src/http/transport-curl.cc
@melroy89
melroy89 merged commit f300abb into master Dec 14, 2023
@melroy89
melroy89 deleted the fix_deprecated_methods_curl branch December 15, 2023 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants