Bump occt to 7.9.3 and swig to 4.4.1#1473
Merged
Merged
Conversation
Reviewer's guide (collapsed on small PRs)Reviewer's GuideUpdates the project and conda packaging to target OCCT 7.9.3 and SWIG 4.4.1, keeping CMake and conda metadata in sync with the new versions. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- Consider centralizing the OCCT and pythonOCC version definitions (e.g., via a single top-level CMake or config file) so that CMakeLists.txt and ci/conda/meta.yaml cannot drift out of sync on future version bumps.
- The SWIG CMake requirement is specified as a closed range (4.2.1...4.4.1) while conda pins exactly 4.4.1; if you intend to support newer 4.x releases, widening or documenting the upper bound would reduce future maintenance when SWIG is updated again.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider centralizing the OCCT and pythonOCC version definitions (e.g., via a single top-level CMake or config file) so that CMakeLists.txt and ci/conda/meta.yaml cannot drift out of sync on future version bumps.
- The SWIG CMake requirement is specified as a closed range (4.2.1...4.4.1) while conda pins exactly 4.4.1; if you intend to support newer 4.x releases, widening or documenting the upper bound would reduce future maintenance when SWIG is updated again.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by Sourcery
Bump pythonOCC and OCCT versions to 7.9.3 and update SWIG dependency range to 4.4.1.
Enhancements:
Build: