Skip to content

Bump occt to 7.9.3 and swig to 4.4.1#1473

Merged
tpaviot merged 1 commit into
masterfrom
review/occt793
Dec 30, 2025
Merged

Bump occt to 7.9.3 and swig to 4.4.1#1473
tpaviot merged 1 commit into
masterfrom
review/occt793

Conversation

@tpaviot
Copy link
Copy Markdown
Owner

@tpaviot tpaviot commented Dec 30, 2025

Summary by Sourcery

Bump pythonOCC and OCCT versions to 7.9.3 and update SWIG dependency range to 4.4.1.

Enhancements:

  • Align project CMake versioning with OCCT 7.9.3 and require SWIG up to 4.4.1.

Build:

  • Update conda recipe to require occt 7.9.3 and swig 4.4.1.

@sourcery-ai
Copy link
Copy Markdown

sourcery-ai Bot commented Dec 30, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates the project and conda packaging to target OCCT 7.9.3 and SWIG 4.4.1, keeping CMake and conda metadata in sync with the new versions.

File-Level Changes

Change Details Files
Align pythonOCC and OCCT versions to 7.9.3 across build and packaging configuration.
  • Update conda recipe OCCT version variable from 7.9.1 to 7.9.3 for host and run dependencies
  • Bump pythonOCC CMake project patch version from 7.9.1 to 7.9.3 to match OCCT
  • Adjust OCCT CMake version constants from 7.9.1 to 7.9.3
ci/conda/meta.yaml
CMakeLists.txt
Raise SWIG toolchain requirement to 4.4.1 in both conda and CMake configuration.
  • Update conda build dependency to require swig 4.4.1 instead of 4.3.1
  • Expand CMake find_package(SWIG) version range upper bound from 4.3.1 to 4.4.1 to match the new requirement
ci/conda/meta.yaml
CMakeLists.txt

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • Consider centralizing the OCCT and pythonOCC version definitions (e.g., via a single top-level CMake or config file) so that CMakeLists.txt and ci/conda/meta.yaml cannot drift out of sync on future version bumps.
  • The SWIG CMake requirement is specified as a closed range (4.2.1...4.4.1) while conda pins exactly 4.4.1; if you intend to support newer 4.x releases, widening or documenting the upper bound would reduce future maintenance when SWIG is updated again.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Consider centralizing the OCCT and pythonOCC version definitions (e.g., via a single top-level CMake or config file) so that CMakeLists.txt and ci/conda/meta.yaml cannot drift out of sync on future version bumps.
- The SWIG CMake requirement is specified as a closed range (4.2.1...4.4.1) while conda pins exactly 4.4.1; if you intend to support newer 4.x releases, widening or documenting the upper bound would reduce future maintenance when SWIG is updated again.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@tpaviot tpaviot merged commit 3476965 into master Dec 30, 2025
11 checks passed
@tpaviot tpaviot deleted the review/occt793 branch December 30, 2025 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant