Improving opt test to include missing values#54
Closed
quidryan wants to merge 1 commit into
Closed
Conversation
Owner
|
Will consider after the revert is completed. Thanks again for catching it. |
Author
|
I wasn't following the previous work that had to be reverted, but wouldn't this test be relevant irrelevant to the state of the JSON-Java repo? This add coverage which did not exist before. |
Owner
|
Well, the tests are not even included in the Maven repo. We keep them release-synced, so there is always a test release to match the JSON release, but there is no requirement for them to be timestamp-synced, if we are rushed. Since @johnjaylward has also made a pull request in #55, we will proceed there. Please take a look at that branch and post if you see any tests that should be added. |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proves out stleary/JSON-java#260