Fix runtime not being python#745
Fix runtime not being python#745mklenbw wants to merge 6 commits intoserverless:masterfrom mklenbw:741-non-python-runtime
Conversation
|
Thanks @mklenbw - sorry for not responding sooner, but I've been very busy lately, I'll try to review this PR by the end of the week |
|
Sure. I'll add it right away and text you. |
|
+1 Also facing this issue. Appreciate the PR! |
|
@pgrzesik |
|
Hey @mklenbw, thank you so much 🙇 Unforutnatelly it looks like formatting is failing, could you please check that? |
|
@pgrzesik Got it fixed. Forgot to run prettier. You should consider including husky. |
|
Hey @mklenbw - thank you, there's a leftover |
|
@pgrzesik |
|
@pgrzesik If someone wants to continue this topic please take my code and get it to work. I would love to see this masterpiece of a plugin in it's full glance again. |
|
No worries, sorry that it became an issue and thanks for all the effors @mklenbw 👍 I'll try to wrap this up over the weekend. I'm trying to keep the lights on with this particular plugin but unfortunately my time has been very limited lately. |
|
+1 for would love to see this fixed |
|
thanks @jameskbride - I'll close this one and respond in other PR |
When runtime is not set to python don't use it as pythonBin.
Closes: #741