Skip to content

Change wording and add examples for Liskov Substitution Principle#251

Open
strunkandwhite wants to merge 1 commit into
ryanmcdermott:masterfrom
strunkandwhite:master
Open

Change wording and add examples for Liskov Substitution Principle#251
strunkandwhite wants to merge 1 commit into
ryanmcdermott:masterfrom
strunkandwhite:master

Conversation

@strunkandwhite
Copy link
Copy Markdown

Hello! Love this repo - incredibly useful, and I've bookmarked it for future reference.

I'd like to suggest a change to the writeup on the Liskov Substitution Principle. The text right now indicates that instances of a parent and child class can be used interchangeably. This is incorrect - the parent can be replaced by the child, but not the other way around. I've updated the wording and added a small illustrative example.

Thanks for maintaining this!

@ryanmcdermott
Copy link
Copy Markdown
Owner

Thanks for your expertise! You're right.

Can you update your commit to not have the code example at the bottom. I like to keep the code examples only in a Good or Bad block

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants