Fix Ractor compatibility regression, add tests - #127
Open
hmcguire-shopify wants to merge 2 commits into
Open
Conversation
The recent change to use `BasicObject.instance_method(:equal?)` broke the ability to share frozen ERB templates across Ractors because `UnboundMethod` isn't shareable. Freezing the `UnboundMethod` _may_ fix the issue (dependong on Ruby version), but replacing the constant with an inline call to the `singleton_class` is simpler (and still avoids calling `equal?` on `@init`). There have previously been many contributions to make ERB Ractor safe, but no tests added to ensure it continues to be Ractor safe, so this commit also adds some regression tests.
Ractor.make_shareable isn't needed if everything is plain `freeze`d
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The recent change to use
BasicObject.instance_method(:equal?)brokethe ability to share frozen ERB templates across Ractors because
UnboundMethodisn't shareable.Freezing the
UnboundMethodmay fix the issue (dependong on Rubyversion), but replacing the constant with an inline call to the
singleton_classis simpler (and still avoids callingequal?on@init).There have previously been many contributions to make ERB Ractor safe,
but no tests added to ensure it continues to be Ractor safe, so this
commit also adds some regression tests.
Simplify Scanner's Ractor safety code
Ractor.make_shareable isn't needed if everything is plain
freezed