Skip to content

Support for rescript 9.1.1 with changed location of binaries - #35

Closed
smh wants to merge 2 commits into
rescript-lang:masterfrom
smh:master
Closed

Support for rescript 9.1.1 with changed location of binaries#35
smh wants to merge 2 commits into
rescript-lang:masterfrom
smh:master

Conversation

@smh

@smh smh commented Apr 18, 2021

Copy link
Copy Markdown
Contributor

Upgraded to rescript-vscode 1.0.8
Handle changed location of bsc binaries

@ryyppy

ryyppy commented Apr 20, 2021

Copy link
Copy Markdown
Member

Awesome! Gonna review this later today.

@ryyppy

ryyppy commented Apr 26, 2021

Copy link
Copy Markdown
Member

Quick update:
The latest updates for the new rescript package / code analysis binary are more thorough than anticipated. I will create a new PR with your commits as a baseline and add all the behavior that's missing + the new, slimmed down version of the server tools.

@ryyppy

ryyppy commented May 6, 2021

Copy link
Copy Markdown
Member

gonna close this one, since I cherrypicked some of your commits for the newest release!

@ryyppy ryyppy closed this May 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants