move JsxDOM.dromProps and JsxDOMStyle from compiler to @rescript/react

[dkirchhof]

s. rescript-lang/rescript#8282

[Freddy03h]

Hi @dkirchhof,
You bumped the version in the PR, but I think this is usually done by the maintainer directly on the master branch when releasing.
Also, maybe this change should be addressed after the ReScript 12 migration? (idk)

[dkirchhof]

Hi @dkirchhof, You bumped the version in the PR, but I think this is usually done by the maintainer directly on the master branch when releasing. Also, maybe this change should be addressed after the ReScript 12 migration? (idk)

Yeah, wasn't sure about the version. Also not sure about the overall plan to migrate the domprops from the compiler repo. There are a lot of discussions.

[tsnobip]

IMO this is going in the right direction. You can try to fix the conflicts. Next step will be to split ReactDOM, may it be with rewatch "features" or by using a monorepo and splitting the packages.

[tsnobip]

@dkirchhof great work!

I think a few things remain:

•  move JsxEvent to ReactDOMEvent.
• move the DOM parts (ReactDOMProps/ReactDOMEvent) out of @rescript/react into their own package (@rescript/react-dom).

Once this is done and WebAPI finally cleaned, we'll:

• vendor this package inside rescript monorepo for tests and such and remove dependencies to this package
• remove the Dom module from the monorepo
• remove Jsx/JsxDOM/JsxDOMStyle/ JsxDOMEvent from the monorepo
• come up with a way to easily provide the module in charge of the JSX function (should we just keep the existing JSX custom config in rescript.json, make it default to ReactDOM, or make it default to a given module ( Jsx?) and move ReactDOM to ReactDOM.Jsx thanks to namespacing, or come up with another mechanism? Making it default to ReactDOM is likely the easiest way forward but it's less agnostic.

[dkirchhof]

For the split between rescript/react and rescript/react-dom should we use another repo?

[tsnobip]

@dkirchhof I think the easiest path would be to move this repo to a yarn monorepo, and split the packages here.

[tsnobip]

I've split the packages, maybe it can be reviewed now? It'll be a good base to work on finalizing the WebAPI bindings.

[fhammerschmidt]

@codex review

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a07783d831

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".