Repository navigation
Fix test_memo_client_counter after the client-state rename - #7741
Merged
FarhanAliRaza merged 1 commit intoNov 5, 2026
Merged
FarhanAliRaza merged 1 commit into
FarhanAliRaza merged 1 commit into
Conversation
test_memo_client_counter hard-coded the JavaScript name a client state
var binds its value to ("Δcounter + 1"). Merging main brought in #6936,
which drops the name of a legacy ClientStateVar created with
global_ref=False and suffixes the emitted identifier with RxClientState,
so the hook now reads `const [cs$0RxClientState, setCs$0] = ...` while
the click handler still read `Δcounter`. That bare identifier resolved
to the button carrying id="Δcounter" through the browser's named
element access, and the counter rendered "[object HTMLButtonElement]1".
Build the increment expression from str(counter.value) instead, with a
{value} placeholder for the direct read and a {source} placeholder for
the eval'd reads, so the test follows whatever identifier Reflex emits.
Use rx.client_state(0) and .set(...) in place of the deprecated
ClientStateVar.create / set_value entry points. rx.client_state rejects
non-ASCII names, so the Unicode case becomes a plain scoped counter;
test_react_compiler_callback_dependencies still covers Unicode bindings
in the Babel dependency prune.
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01ESN8Dfnc4fUrUVcPsqaLGk
Contributor
[Low impact] This test-only change appears safe to merge. SummaryUpdates
No actionable issues found. Tests were not run during this review. Reviews (1) · Last reviewed commit: "Derive the client counter test's JS from..." · Reviewed by Greptile |
Merging this PR will not alter performance1 warning
Comparing |
8 tasks done
FarhanAliRaza
merged commit Nov 5, 2026
5c8fb85
into
farhan/react-compiler-generation-revive
7 checks passed
FarhanAliRaza
added a commit
that referenced
this pull request
Nov 10, 2026
* Let React Compiler optimize generated components Replays #7272 onto main. That PR auto-closed when its base branch was deleted after #7234 merged; its own changes were the diff between the base-branch head it last merged (07aa53c) and its head (4f3e5db), covering commits c01f4d4, 755ddba and 4f3e5db. Change the patterns Reflex emits that made React Compiler bail out: register refs through a useRegisteredRef hook instead of writing to refs during render, wrap generateUUID in an inline useMemo callback, list only referenced bindings as useCallback dependencies, disable function outlining, and describe Emotion's jsx() to the compiler as JSX. Pin the experimental compiler, which accepts refs passed to jsx(). Add an auto_memoize config option (default True). False removes MemoizeStatefulPlugin from page compilation so the compiler memoizes whole pages; app-root memoization is unchanged. Conflicts with main: #7586 removed hook positions, so the ref hook no longer passes VarData(position=INTERNAL); #7435 removed backend_state_mismatch from state.js, so it stays removed. Claude-Session: https://claude.ai/code/session_01LwJUCTv3FVWzi1UoUpyMLT * Tie the callback prune pattern to Python names, tidy tests and fragment Export GENERATED_EVENT_CALLBACK from the React Compiler adapter and test it against the names get_memoized_event_triggers produces, so a rename on either side fails a test instead of silently restoring compiler bailouts. Drop the Unicode stale-callback claim from the reflex-base fragment: main never had that bug. Move inline test imports to module level. * Run the auto_memoize compile_app test as a dry run Without dry_run, REFLEX_SKIP_COMPILE or a leftover .web/nocompile file made compile_app return before building the page plugins, and the test wrote into the working directory's .web. * Derive the client counter test's JS from the var's real identifier (#7741) test_memo_client_counter hard-coded the JavaScript name a client state var binds its value to ("Δcounter + 1"). Merging main brought in #6936, which drops the name of a legacy ClientStateVar created with global_ref=False and suffixes the emitted identifier with RxClientState, so the hook now reads `const [cs$0RxClientState, setCs$0] = ...` while the click handler still read `Δcounter`. That bare identifier resolved to the button carrying id="Δcounter" through the browser's named element access, and the counter rendered "[object HTMLButtonElement]1". Build the increment expression from str(counter.value) instead, with a {value} placeholder for the direct read and a {source} placeholder for the eval'd reads, so the test follows whatever identifier Reflex emits. Use rx.client_state(0) and .set(...) in place of the deprecated ClientStateVar.create / set_value entry points. rx.client_state rejects non-ASCII names, so the Unicode case becomes a plain scoped counter; test_react_compiler_callback_dependencies still covers Unicode bindings in the Babel dependency prune. Claude-Session: https://claude.ai/code/session_01ESN8Dfnc4fUrUVcPsqaLGk Co-authored-by: Claude <noreply@anthropic.com> * Keep lifecycle events in their branch when auto_memoize is off Without memo wrappers, on_mount and on_unmount hooks were hoisted to the page function. A hidden rx.cond branch fired on_mount on page load, and an rx.foreach item hook read the loop variable outside the loop. Render the events as a MountEffect element beside the component instead. * Warn once that react_compiler is experimental * Render lifecycle events as elements in every compile mode An on_mount inside rx.foreach was hoisted to the Foreach memo body, where the loop variable does not exist, so the page crashed. Run InlineLifecyclePlugin with auto-memoization on as well, and rewrite a snapshot subtree before the memoize plugin seals it. * Limit the lifecycle element plugin to the experimental options Default apps keep the generated code they have on main. The plugin runs with react_compiler=True or auto_memoize=False. * Keep scope wrappers when auto_memoize is off; remove MountEffect The MountEffect element kept one instance across an rx.cond branch switch, so no lifecycle event fired, and its fragment hid the child from an as_child parent. With auto_memoize=False, still wrap a component that has a lifecycle event or hooks of its own in a memo component. A wrapper has its own identity and forwards props, and it keeps the hooks in their rx.cond branch. * Test rx.foreach item lifecycle with auto_memoize off; complete the docstring - An item's lifecycle hook compiles into a wrapper inside the loop body and receives the loop variable when auto_memoize is off. - default_page_plugins names the snapshot boundary and ALWAYS exceptions. Claude-Session: https://claude.ai/code/session_01LwJUCVweoEhh1JsZA7emsa * Keep lifecycle of prop components in a wrapper when auto_memoize is off With auto_memoize off, a lifecycle event of a component held in a prop moved into the page function, so it fired on page load even inside a hidden rx.cond branch. The scope-only rule now uses _has_instance_hooks, which also checks components held in props. Claude-Session: https://claude.ai/code/session_01LwJUCVweoEhh1JsZA7emsa --------- Co-authored-by: Masen Furer <m_github@0x26.net> Co-authored-by: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the
integration-app-harness-playwrightfailures on #7694 after a7400b3 mergedmainin (failing run).All Submissions:
Type of change
Why the test failed
test_memo_client_counterhard-coded the JavaScript identifier a client state var binds its value to, e.g."Δcounter + 1"forClientStateVar.create("Δcounter", default=0, global_ref=False). Mergingmainbrought in #6936, which changed two things:global_ref=Falseis passed, so the var gets a generated store name (cs$0).RxClientStatesuffix.The hook became
const [cs$0RxClientState, setCs$0] = useClientState(0, "cs$0")while the click handler still readΔcounter. That bare identifier is not a binding anywhere in the component, so the browser resolved it through named element access to the<button id="Δcounter">, and the counter rendered"[object HTMLButtonElement]1". Theevalvariants failed the same way. The previous commit on the branch passed this workflow (run 41491674721).Changes
str(counter.value), with a{value}placeholder for the direct read and a{source}placeholder (the identifier as a JSON string literal) for theevaland nested-evalreads, so the test follows whatever identifier Reflex emits.rx.client_state(0)and.set(...)instead of the deprecatedClientStateVar.createandset_value, which also removes the deprecation warnings from the run.rx.client_staterejects non-ASCII names, so the Unicode case becomes a plain scoped counter named by its button ID. Unicode bindings in the Babel dependency prune are still covered bytest_react_compiler_callback_dependencies, which writesΔvaluebindings directly.Generated code after the change:
Testing
uv run pytest tests/integration/tests_playwright/test_memo.py -k test_memo_client_counter: 12 passed (dev and prod, compiler on and off, three counters each).uv run ruff check,uv run ruff format --check, anduv run pyrighton the test file: clean.uv run reflex-release changelog-check: no packaged source changes, so no news fragment is required.Generated by Claude Code