Skip to content

"transient dependencies" -> "transitive dependencies"#7341

Merged
zpao merged 1 commit into
react:masterfrom
amasad:patch-1
Jul 25, 2016
Merged

"transient dependencies" -> "transitive dependencies"#7341
zpao merged 1 commit into
react:masterfrom
amasad:patch-1

Conversation

@amasad

@amasad amasad commented Jul 23, 2016

Copy link
Copy Markdown
Contributor

I think that's what you meant -- although with npm dependencies are kind of transient :P

I think that's what you meant -- although with npm dependencies are kind of transient :P
@ghost

ghost commented Jul 23, 2016

Copy link
Copy Markdown

Thank you for your pull request. As you may know, we require contributors to sign our Contributor License Agreement, and we don't seem to have you on file and listed as active anymore. In order for us to review and merge your code, please email cla@fb.com with your details so we can update your status.

@amasad

amasad commented Jul 23, 2016

Copy link
Copy Markdown
Contributor Author

CLA form seems to be down.

@gaearon

gaearon commented Jul 23, 2016

Copy link
Copy Markdown
Collaborator

Oh thanks :P
Can you send a PR against the repo as well?

@amasad

amasad commented Jul 25, 2016

Copy link
Copy Markdown
Contributor Author

@zpao

zpao commented Jul 25, 2016

Copy link
Copy Markdown
Contributor

(y) thanks!

@zpao zpao merged commit d157827 into react:master Jul 25, 2016
zpao pushed a commit that referenced this pull request Jul 28, 2016
I think that's what you meant -- although with npm dependencies are kind of transient :P
(cherry picked from commit d157827)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants