Skip to content

Env var set to empty in shell does not override .env file #5833

Closed

Description

@geritol

Is this a bug report?

yes

Environment

System:
OS: macOS 10.14
CPU: x64 Intel(R) Core(TM) i5-5257U CPU @ 2.70GHz
Binaries:
Node: 8.12.0 - /usr/local/bin/node
npm: 6.4.1 - /usr/local/bin/npm
Browsers:
Chrome: 70.0.3538.102
Firefox: 63.0
Safari: 12.0
npmPackages:
react: ^16.6.3 => 16.6.3
react-dom: ^16.6.3 => 16.6.3
react-scripts: 2.1.1 => 2.1.1
npmGlobalPackages:
create-react-app: Not Found

Steps to Reproduce

(Write your steps here:)

  1. put REACT_APP_VAR=test in .env.production
  2. put console.log("VAR", process.env.REACT_APP_VAR); inApp.js
  3. run REACT_APP_VAR= npm run build
  4. serve the app (serve -s build)

Expected Behavior

The console should containt: VAR

Actual Behavior

The console contains VAR test

Reproducible Demo

https://github.com/geritol/cra-env-repro

Similar to #4002 but the issue here is that you cannot override with an empty value the vars provided in .env files.

Activity

  1. iansu commented on Nov 16, 2018

    @iansu
    Contributor

    Based on the discussion in #4002 it sounds like this might have something to do with dotenv-expand. Can you try removing that dependency from your project and testing again?

  2. geritol commented on Nov 17, 2018

    @geritol
    Author

    Removed dotenv-expand from react-scripts/config/env.js line 43 and the empty override behaves as expected!

  3. iansu commented on Nov 17, 2018

    @iansu
    Contributor

    Thanks for checking that. Can you create an issue with dotenv-expand and reference this issue so we can track it?

  4. stale commented on Dec 17, 2018

    @stale

    This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

  5. stale commented on Jan 18, 2019

    @stale

    This issue has been automatically marked as stale because it has not had any recent activity. It will be closed in 5 days if no further activity occurs.

  6. stale commented on Jan 26, 2019

    @stale

    This issue has been automatically closed because it has not had any recent activity. If you have a question or comment, please open a new issue.

  7. locked and limited conversation to collaborators on Jan 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions