Repository navigation
Conversation
Contributor
|
Diff from mypy_primer, showing the effect of this PR on open source code: sphinx (https://github.com/sphinx-doc/sphinx)
- sphinx/builders/_epub_base.py:34:1: note: See https://mypy.readthedocs.io/en/stable/running_mypy.html#missing-imports
|
thomas-maschler
suggested changes
Oct 26, 2026
| indexes: Indexes | None = None, | ||
| out: NDArray[Any] | None = None, | ||
| window: WindowInput | None = None, | ||
| masked: Literal[True] = True, |
Contributor
There was a problem hiding this comment.
The runtime default is False. Make masked a kwarg and don't pass a default to avoid matches with this overload in case users don't pass masked
Suggested change
| masked: Literal[True] = True, | |
| *, | |
| masked: Literal[True], |
| fill_value: NumType | None = None, | ||
| out_dtype: DTypeLike | None = None, | ||
| ) -> NDArray[Any]: ... | ||
| ) -> NDArray[Any] | ma.MaskedArray[Any, Any]: ... |
Contributor
There was a problem hiding this comment.
With masked=False results will always be a simple NDArray
Suggested change
| ) -> NDArray[Any] | ma.MaskedArray[Any, Any]: ... | |
| ) -> NDArray[Any]: ... |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
DatasetBase.crs: Updated the return type annotation instubs/rasterio/rasterio/_base.pyitoCRS | None.DatasetReaderBase.read: Added@overloaddefinitions instubs/rasterio/rasterio/_io.pyiso that passingmasked=Truereturnsnumpy.ma.MaskedArray.ruffformatting across thestubs/rasteriodirectory.Verification
python tests/check_typeshed_structure.py).python -m ruff format --check stubs/rasterio).python tests/mypy_test.py stubs/rasterio).