Repository navigation
Give class-closure cells private names so they don't collide with freevars - #159131
Draft
iritkatriel wants to merge 1 commit into
Draft
iritkatriel wants to merge 1 commit into
iritkatriel wants to merge 1 commit into
Conversation
…evars Store the class unit's synthetic cells as __classcell__/__classdictcell__ instead of __class__/__classdict__, and map method freevars of the public names to those private cells in LookupArg. This keeps an enclosing free named __class__ distinct from the class cell in localsplus. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
__classcell__/__classdictcell__instead of__class__/__classdict__._PyCompile_LookupArg.__class__distinct from the class cell inlocalsplus, removing the need to special-case those names as if they were ordinary freevars that share a spelling with the class cell.Test plan
./python.exe -m test test_super test_listcomps test_symtableMade with Cursor