Repository navigation
Conversation
ashm-dev
requested review from
brandtbucher,
markshannon and
savannahostrowski
as code owners
October 10, 2026 12:36
picnixz
reviewed
Oct 10, 2026
picnixz
left a comment
Member
There was a problem hiding this comment.
I am pretty sure we already had this kind of PR with the memcpy stuff that you once posted and IIRC it was not enough, but maybe this was not this specific code (and maybe it was on aarch64 only i do not remember).
Can you find that issue and see if this change fixed it? IIRC the memcpy was not enoigh for some reason or ended up being impacting performances.
Comment on lines
+21
to
+25
| static inline _Py_CODEUNIT* _Py_NO_SANITIZE_UNDEFINED | ||
| _PyJIT_Entry(jit_func jitted, _PyInterpreterFrame *frame, | ||
| _PyStackRef *stack_pointer, PyThreadState *tstate) | ||
| { | ||
| return jitted(frame, stack_pointer, tstate); |
Member
There was a problem hiding this comment.
Suggested change
| static inline _Py_CODEUNIT* _Py_NO_SANITIZE_UNDEFINED | |
| _PyJIT_Entry(jit_func jitted, _PyInterpreterFrame *frame, | |
| _PyStackRef *stack_pointer, PyThreadState *tstate) | |
| { | |
| return jitted(frame, stack_pointer, tstate); | |
| static inline _Py_CODEUNIT *_Py_NO_SANITIZE_UNDEFINED | |
| _PyJIT_Entry(jit_func jitted, _PyInterpreterFrame *frame, | |
| _PyStackRef *stack_pointer, PyThreadState *tstate) | |
| { | |
| return jitted(frame, stack_pointer, tstate); |
| @@ -0,0 +1,3 @@ | |||
| Fix crashes when entering JIT-compiled code with UndefinedBehaviorSanitizer | |||
Member
There was a problem hiding this comment.
Those are not really fixed just suppressed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.