Repository navigation
Conversation
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
Documentation build overview
|
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Correct the library documentation and docstring for
msvcrt.getch()to distinguish reading Ctrl+C as a character from invoking a SIGINT handler. Regenerate the Argument Clinic header to keep the built-in help text in sync.The revised wording says that Ctrl+C, when pressed while the function is waiting for input, can be read as
b'\x03'without invoking thesignal.SIGINThandler. It avoids making an unconditional guarantee across Windows console environments. Runtime behavior is unchanged.Validation:
signal.signal(signal.SIGINT, handler): Ctrl+C duringgetch()returnedb'\x03'without calling the handler. In a separate input phase, Ctrl+C duringinput()called the handler with SIGINT (2), after whichinput()raisedEOFError.sphinx-lintforDoc/library/msvcrt.rstandgit diff --check.-W --keep-goingusing the cached environment; the updated build passed. The initial source-reading pass for the original change reported an existing duplicatecustomizationlabel in the unchangedDoc/using/windows.rstandDoc/reference/datamodel.rstfiles.