Repository navigation
Conversation
Add a critical section to `PyFunction_GetAnnotations()` to prevent data races in free-threaded builds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes gh-159091.
The Python-level getter mentioned in issue is already protected by a critical section generated by Argument Clinic. The missing lock is in
PyFunction_GetAnnotations(), which accesses and may replacefunc_annotationswithout holding the function object's critical section.This adds the lock to the C API and a free-threading test that races C API reads against
__annotations__assignments. The race is only reliably detected in a TSAN build.